https://bugzilla.redhat.com/show_bug.cgi?id=1677668 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- So, here's a first pass... > %global provider github > %global provider_tld com > %global project coreos > %global repo coreos-installer > # https://github.com/coreos/coreos-installer > %global provider_prefix %{provider}.%{provider_tld}/%{project}/%{repo} > %global import_path %{provider_prefix} > %global commit 081d4bed42489a48e95f559022d96f4999e56cbd > %global shortcommit %(c=%{commit}; echo ${c:0:7}) Holy crap, this is so much overkill. You seem to only need %commit and %shortcommit. All the rest could be flattened. > URL: https://%{provider_prefix} > Source0: https://%{provider_prefix}/archive/%{commit}/%{repo}-%{shortcommit}.tar.gz This can be simplified to the following: URL: https://github.com/coreos/%{name} Source0: %{url}/archive/%{commit}/%{name}-%{shortcommit}.tar.gz > # setup command reference: http://ftp.rpm.org/max-rpm/s1-rpm-inside-macros.html > # unpack source0 and apply patches > %setup -T -b 0 -q -n %{repo}-%{commit} This can be simplified to just "%autosetup -n %{name}-%{commit} -p1" > Requires: %{name} = %{version}-%{release} > Requires: coreos-installer You already have "Requires: %{name} = %{version}-%{release}", you don't need "Requires: coreos-installer" too. The second "BuildArch: noarch" is redundant. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
