[Bug 1665563] Review Request: python-rangehttpserver - SimpleHTTPServer with support for Range requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1665563



--- Comment #10 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
The __main__ file should not be removed. It allows the package to be executed
directly (python -m ...). Removing this file would make the package in fedora
behave differently than the upstream package, and we don't want that. Please
just chmod it like the other file.

I'm not too happy about this comment:
> # the test server_test removed because need network

It doesn't seem to be true, the tests only refer to localhost. If they fail,
then it's because of some different reason.

Looks good otherwise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux