[Bug 1665563] Review Request: python-rangehttpserver - SimpleHTTPServer with support for Range requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1665563



--- Comment #8 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
Sorry for the delay, Luis! I was out all evening. The package is almost ready:


* spec and package name do not match: they should both be completely lowercase,
or they should both be RangeHTTPServer, not a mixture of the two.

* still have errors on these files. The shebang needs to be removed here (since
these files cannot be run as scripts: they are only part of the module and will
be imported only).
python3-RangeHTTPServer.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/RangeHTTPServer/__init__.py 644
/usr/bin/python 
python3-RangeHTTPServer.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/RangeHTTPServer/__main__.py 644
/usr/bin/python 

* please remove the unused bcond_with statement.
* please add a comment to explain why that test file was removed

Cheers,
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux