https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #9 from Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> --- Hi Tom, fixing all the small issues I brought up (I had hoped someone more experienced than me would have reviewed the package by now). I'm still hesitant to formally reviewing this package but I think I found some more issues: hcc package =============== - contains a folder "/usr/include/experimental" which should probably be stored as "/usr/include/hcc/experimental" e.g. "algorithm" (no extension?) refers to "../hcc.hpp" - empty "/lib" folder? - hcc-config.cmake contains references to "/opt/rocm" (should be /usr/include/hcc?) - also there it contains something like set_and_check( hcc_INCLUDE_DIR "${PACKAGE_PREFIX_DIR}/include" ) - I'm not sure where this cmake file is actually used but I suspect this should point to "${PACKAGE_PREFIX_DIR}/include/hcc" as well - are the "cmake" files actually required by hcc directly? - hcc.spec: for f in clamp-device clamp-embed clamp-assemble clamp-link hc-kernel-assemble hc-host-assemble error-check; do mv %{buildroot}{/usr,%{_libexecdir}/hcc}/bin/$f done I'd prefer "install --preserve-timestamps" hcc-runtime package ===================== - empty "/lib" folder? - does not install a license file! rocm-device-libs ===================== - does not install a license file! hcc-runtime-devel ===================== Note: Package has .a files: hcc-runtime-devel. Does not provide -static: hcc-runtime-devel. -> I assume you are aware of the static library and it is actually required by some part of the ROCm stack -> Fedora guidelines say that the static library MUST be in a -static package (https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries) ---------- I was unable to check the license of all sources (due to the huge number of sources files + the perl check script taking forever) so far. Also several other points which I could not check yet. I'm also not sure if llvm counts as a bundled library and must be declared as such (https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling), see also Fedora's "rust" package. Tom: I assume the rocm stack currently does not work against any upstream version of llvm, right? Is there an official way of trying to build with a vanilla llvm? My plan is to work through the rest of the review items (though that will take some time) and also check your "hip" package in parallel. That way I hope to validate the packaging decisions made in the "hcc" package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
