https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #8 from Tom Stellard <tstellar@xxxxxxxxxx> --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-2.0/fedora-rawhide-x86_64/00849663-hcc/hcc.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-2.0/fedora-rawhide-x86_64/00849663-hcc/hcc-1.3.18505-1.rocm2.0.0.fc30.src.rpm (In reply to Felix Schwarz from comment #7) > I noticed some things: > The hcc package contains multiple copies of the same header file, e.g. > kalmar_aligned_alloc.h is available via /usr/include/ and /usr/include/hcc/. > I saw a patch in the SRPM which tried to move everything to the "hcc" > subdirectory but I guess you missed at least on spot. > I've fixed this now so that everything is in /usr/include/hcc. The previous build had all the headers symlinked into /usr/include because this is what some apps, like hip, expect. I've also updated the output of hcc-config --cxxflags to add /usr/include/hcc as an include directory to support applications that don't use the hcc prefix in their #include directives. > Also there are some rpmlint errors (which I guess you are aware of already), > e.g. that "hcc" requires "hcc-runtime-devel". As hcc is a compiler I think > that is basically ok (compiler requires header files for its "standard > library") but maybe these files are just part of the "hcc-runtime"? This is ok for a compiler. It's possible to use the hcc-runtime without hcc, I think hip may do this, so this is why I separated the headers and libraries into separate packages. > rpmlint also complained about some rpaths in binaries like hcc and libraries > like "LLVMPromotePointerKernArgsToGlobal.so". > hcc uses and depends on internal libraries, so this is OK according to https://docs.fedoraproject.org/en-US/packaging-guidelines/#_rpath_for_internal_libraries > "hcc-config --cxxflags" still returns "-I/opt/rocm/include" but lacks > "-I/usr/include/hcc/". Same applies to "clamp-config" (and I was wondering These include paths are fixed now. > why "clamp-config" was available at all as I read that ROCm 2.0 drop C++ AMP > support - but that is likely due to my limited understanding/an upstream > issue). I read that too, but upstream still ships this so it is an upstream issue -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
