https://bugzilla.redhat.com/show_bug.cgi?id=1661034 --- Comment #3 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- Hello, this is an unofficial review. Please read this for your reference. Summary ======= 1. rpmlint success 2. The 'Group' tag should not be used 3. Other suggestions 4. Appendix 1: Koji scratch build succeeded 5. Appendix 2: dependency generator no problems Details ======= 1. rpmlint success ------------------ No problems. Here is the output:: $ rpmlint -i /home/vagrant/rpmbuild/RPMS/noarch/python3-edgegrid-1.1.1-1.fc29.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -i python-edgegrid.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint -i /home/vagrant/rpmbuild/SRPMS/python-edgegrid-1.1.1-1.fc29.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. 2. The 'Group' tag should not be used The Group: tag should not be used. Here is the guideline. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections 3. Other suggestions -------------------- The 'URL:' tag might be better than the 'Url:' tag for legibility. I found a 'URL:' tag in the following example spec file while it's just an example and it might not be a part of guidelines. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_python_spec_file The following python guideline says the %python_provide macro should be used. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_reviewer_checklist Currently I found no %python_provide in the spec file although generated provides are correct:: ~/rpmbuild/RPMS/noarch $ rpm -q --provides ~/rpmbuild/RPMS/noarch/python3-edgegrid-1.1.1-1.fc29.noarch.rpm python3-edgegrid = 1.1.1-1.fc29 python3.7dist(edgegrid-python) = 1.1.1 python3dist(edgegrid-python) = 1.1.1 Appendix 1: Koji scratch build succeeded ---------------------------------------- https://koji.fedoraproject.org/koji/taskinfo?taskID=32679130 Appendix 2: dependency generator no problems -------------------------------------------- Generated requires are correct:: [vagrant@localhost python-edgegrid]$ find ~/rpmbuild/|grep edgegrid|grep requires.txt| xargs cat requests>=2.3.0 pyOpenSSL>=0.13 ndg-httpsclient pyasn1 urllib3 [vagrant@localhost python-edgegrid]$ rpm -q --requires ~/rpmbuild/RPMS/noarch/python3-edgegrid-1.1.1-1.fc29.noarch.rpm |grep python3.*dist python3.7dist(ndg-httpsclient) python3.7dist(pyasn1) python3.7dist(pyopenssl) >= 0.13 python3.7dist(requests) >= 2.3.0 python3.7dist(urllib3) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
