https://bugzilla.redhat.com/show_bug.cgi?id=1672274 --- Comment #2 from Paul Howarth <paul@xxxxxxxxxxxx> --- (In reply to Petr Pisar from comment #1) > TODO: Do not build-require 'coreutils'. I cannot see where it could be used. %{_fixperms} is implemented using chmod, which comes from coreutils. > TODO: Build-require 'perl(:VERSION) >= 5.8.1' (Makefile.PL:1). As this is a very old distribution with few dependencies, I'm intending to build it for EPEL-6 as well as Fedora and EPEL-7. The perl(:VERSION) virtual dependency isn't available in EPEL-6. And even when EL-5 was still supported, all current Fedoras and EL releases would have a sufficiently recent version so I don't think this is a big miss. > TODO: Use '%{make_build}' instead if 'make %{?_smp_mflags}'. This is a new > recommended style > <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make>. Again, this doesn't work in EPEL-6 but I'll bear it in mind for other packages that aren't targeting such an old release. > TODO: Add '>= 6.76' to perl(ExtUtils::MakeMaker) dependency, 'NO_PACKLIST=1 > NO_PERLLOCAL=1' to 'perl Makefile.PL' command and call '%{make_install}' > instead of 'make pure_install DESTDIR=%{buildroot}' (a new recommend style > <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros>) and > remove the find command. I can do this Fedora-only packages. > TODO: Do not build-require 'perl(Time::HiRes)'. It's not used because > t/_dict.rx file does not exist (alternatively you can try to generate the > file using a t/dict2rx.pl scrip as shown in t/01-dict.t's BEGIN block. In the -2 release I have fixed this test and run it after the main test suite (as it needs a parameter passing to it). It takes quite a while to run: on my i7 builder it takes 3-5 minutes on EPEL-7 and Fedora but almost 15 minutes on EPEL-6. Thanks for the review Petr. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
