https://bugzilla.redhat.com/show_bug.cgi?id=1672274 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Url and Source0 addresses are Ok. Source archive (SHA-256: fb2bf94ed8dbc1f4a95d9fc8f710cb67b3f796c6efc9c4bb4c2cfa3ebaa1c5fa) is original. Ok. Summary verified from lib/Regexp/Trie.pm. Ok. Description is Ok. License verified from README and lib/Regexp/Trie.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: Do not build-require 'coreutils'. I cannot see where it could be used. TODO: Build-require 'perl(:VERSION) >= 5.8.1' (Makefile.PL:1). TODO: Use '%{make_build}' instead if 'make %{?_smp_mflags}'. This is a new recommended style <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make>. TODO: Add '>= 6.76' to perl(ExtUtils::MakeMaker) dependency, 'NO_PACKLIST=1 NO_PERLLOCAL=1' to 'perl Makefile.PL' command and call '%{make_install}' instead of 'make pure_install DESTDIR=%{buildroot}' (a new recommend style <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros>) and remove the find command. TODO: Do not build-require 'perl(Time::HiRes)'. It's not used because t/_dict.rx file does not exist (alternatively you can try to generate the file using a t/dict2rx.pl scrip as shown in t/01-dict.t's BEGIN block. $ rpmlint perl-Regexp-Trie.spec ../SRPMS/perl-Regexp-Trie-0.02-1.fc30.src.rpm ../RPMS/noarch/perl-Regexp-Trie-0.02-1.fc30.noarch.rpm perl-Regexp-Trie.src: W: spelling-error Summary(en_US) ized -> zed, sized, iced perl-Regexp-Trie.src: W: spelling-error %description -l en_US ized -> zed, sized, iced perl-Regexp-Trie.src: W: spelling-error %description -l en_US a's -> A's, as, la's perl-Regexp-Trie.noarch: W: spelling-error Summary(en_US) ized -> zed, sized, iced perl-Regexp-Trie.noarch: W: spelling-error %description -l en_US ized -> zed, sized, iced perl-Regexp-Trie.noarch: W: spelling-error %description -l en_US a's -> A's, as, la's 2 packages and 1 specfiles checked; 0 errors, 6 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Regexp-Trie-0.02-1.fc30.noarch.rpm drwxr-xr-x 2 root root 0 Feb 5 09:14 /usr/share/doc/perl-Regexp-Trie -rw-r--r-- 1 root root 340 Apr 27 2006 /usr/share/doc/perl-Regexp-Trie/Changes -rw-r--r-- 1 root root 1276 Apr 27 2006 /usr/share/doc/perl-Regexp-Trie/README -rw-r--r-- 1 root root 1797 Feb 5 09:14 /usr/share/man/man3/Regexp::Trie.3pm.gz drwxr-xr-x 2 root root 0 Feb 5 09:14 /usr/share/perl5/vendor_perl/Regexp -rw-r--r-- 1 root root 2644 Apr 27 2006 /usr/share/perl5/vendor_perl/Regexp/Trie.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Regexp-Trie-0.02-1.fc30.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(:VERSION) >= 5.8.1 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Regexp-Trie-0.02-1.fc30.noarch.rpm | sort -f | uniq -c 1 perl(Regexp::Trie) = 0.2 1 perl-Regexp-Trie = 0.02-1.fc30 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Regexp-Trie-0.02-1.fc30.noarch.rpm Binary dependencies are resolvable. Ok. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please consider fixing the 'TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
