https://bugzilla.redhat.com/show_bug.cgi?id=1671571 --- Comment #9 from Justin W. Flory <jflory7@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #7) > It's not. You just forgot to remove the corresponding entry from the %files > section - and now it can't find the file that you removed - that's all. (In reply to Dridi Boukelmoune from comment #8) > Fabio, I know that our guidelines strongly advise against static linking > (and bundling in general) but I find it sad to prevent end-users to > statically build software on top of Fedora if that's what they want and > upstream provides the means. But if that's our guidelines, I can live > without the static library and I personally don't care since I integrate > %{_bindir}/playerctl in my local setup. I took the middle-ground approach and built a separate, optional package with the static libraries. The updated commit [1] passed successfully Koji [2][3] and COPR [4]. An updated SRPM is also available [5]. (In reply to Dridi Boukelmoune from comment #8) > Justin, a static library is not code you run, but code you (statically) link > to as part of a build process, that's why I moved it to the -devel > sub-package. It could have also lived in a -static sub-packages too, you can > find such occurrences in the repositories. Thanks for the explanation. -- [1] https://pagure.io/jflory7-rpm-specs/c/ec957e11ed6307b08e5031f5a35451a4761cfb3c?branch=master [2] https://koji.fedoraproject.org/koji/taskinfo?taskID=32545025 [3] https://koji.fedoraproject.org/koji/taskinfo?taskID=32545018 [4] https://copr.fedorainfracloud.org/coprs/jflory7/playerctl/build/854366/ [5] https://pagure.io/jflory7-rpm-specs/blob/master/f/rpmbuild/SRPMS/playerctl-2.0.1-4.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
