https://bugzilla.redhat.com/show_bug.cgi?id=1666836 --- Comment #6 from Tom Stellard <tstellar@xxxxxxxxxx> --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-2.0/fedora-rawhide-x86_64/00849974-rocminfo/rocminfo.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-2.0/fedora-rawhide-x86_64/00849974-rocminfo/rocminfo-1.0.0-1.fc30.src.rpm (In reply to Felix Schwarz from comment #5) > well, I think this package is simple enough so I'll just jump :-) > > tldr: Package looks good, just two trivial items and one error. > > 1. SPEC file contains unused "commit"/shortcommit" definitions. I removed these definitions. > 2. "Packages should try to preserve timestamps of original installed files" > "install" does not use "--preserve-timestamps". Currently this has no > effect because "rocm_agent_enumerator" is patched anyway but if you switch > to a future rocminfo release it might be nice to keep the timestamps. I've added the -p flag to the install commands. > 3. package only builds on x86_64 (and AFAIK upstream only supports that > architecture) > but ExcludeArch is not used ( > https://koji.fedoraproject.org/koji/taskinfo?taskID=32225953 ) > This might be even a case for ExclusiveArch. > There has been interested in ROCm on aarch64 and we already build the rocr-runtime and libhsakmt for aarch64, so I patched the package to fix the build on aarch64 and added ExclusiveArch for x86_64 and aarch64. > No other issues spotted by fedora-review (disregarding the usual quirks like > multiple packages owning /usr/lib/.build-id). I'll paste the full template > once the package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
