https://bugzilla.redhat.com/show_bug.cgi?id=1666836 Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |fschwarz@xxxxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #5 from Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> --- well, I think this package is simple enough so I'll just jump :-) tldr: Package looks good, just two trivial items and one error. 1. SPEC file contains unused "commit"/shortcommit" definitions. 2. "Packages should try to preserve timestamps of original installed files" "install" does not use "--preserve-timestamps". Currently this has no effect because "rocm_agent_enumerator" is patched anyway but if you switch to a future rocminfo release it might be nice to keep the timestamps. 3. package only builds on x86_64 (and AFAIK upstream only supports that architecture) but ExcludeArch is not used ( https://koji.fedoraproject.org/koji/taskinfo?taskID=32225953 ) This might be even a case for ExclusiveArch. No other issues spotted by fedora-review (disregarding the usual quirks like multiple packages owning /usr/lib/.build-id). I'll paste the full template once the package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
