https://bugzilla.redhat.com/show_bug.cgi?id=1663642 --- Comment #6 from Carl George <carl@george.computer> --- > Why? SPEC must only be UTF-8 encoded, I don't recall any rules against using > proper quoting characters. > Why? The changelog entries are not sentences. I thought these things were in the guidelines somewhere, but I can't find it now so I must have been mistaken. My personal preferences aside, keep the fancy quotes and lowercase if you like. > My reading of the above is that it's not necessary if subpackage is named > python3-%{pypi_name}. "In order to make the switch from Python 2 to Python 3 automatic, all packages that provide python3-%{srcname} (for any %{srcname}) SHOULD use the %python_provide macro with the package name" [0] It currently evaluates to an empty string with a python3-* argument, but in the future the macro definition will change so that python3-asynctest provides python-asynctest. As you can see it is a SHOULD item, so it's not strictly a blocker, but if you leave it out you are adding to the manual work that must eventually be done when unversioned python becomes python3 distribution-wide. > No. All current Fedora releases and EPEL7 have setuptools newer than 30.3.0. > Also, python3-setuptools is pulled in by python3-devel. "MUST: All build dependencies must be listed in BuildRequires" [1] Just because something happens to get installed in the build root doesn't mean you don't need to list it. The project's setup.py file imports setuptools, so it's a build requirement. You don't have to include the minimum version, but there is no reason not to since upstream has been courteous enough to mention it. Thanks for taking care of the test suite stuff, I'm able to run fedora-review now. Please take care of this rpmlint error [2]: python3-asynctest.noarch: E: summary-too-long C Enhance the standard unittest package with features for testing asyncio libraries [0]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/ [2]: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
