https://bugzilla.redhat.com/show_bug.cgi?id=1663642 --- Comment #5 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Carl George from comment #4) > Please address the other items I listed in my first comment. > > I also noticed you removed the python_provide line entirely. It's still > needed, and should look like this for your spec file: > > %{?python_provide:%python_provide python3-asynctest} > > See > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides > for more details. My reading of the above is that it's not necessary if subpackage is named python3-%{pypi_name}. It seems to evaluate to empty string, too. [mockbuild@06036e176d6b4146ad180aa2c6c53351 ~]$ rpm --eval '%{?python_provide:%python_provide python3-asynctest}' [mockbuild@06036e176d6b4146ad180aa2c6c53351 ~]$ (In reply to Carl George from comment #1) > * The summary and description lines should be no longer than 80 characters > [1]. Done. > * Replace fancy single and double quotes (’ and ”) in description with > standard ascii quotes (' and "). Why? SPEC must only be UTF-8 encoded, I don't recall any rules against using proper quoting characters. > * Use the %pypi_source macro to define Source0 [2]. Done. > * Upstream uses setuptools in setup.py [3], so it needs to be listed as a > build requirement. Furthermore, upstream specifically calls out setuptools > >= 30.3.0 [4], so that minimum version requirement should be used with the > build requirement. No. All current Fedora releases and EPEL7 have setuptools newer than 30.3.0. Also, python3-setuptools is pulled in by python3-devel. > * The %python_provides macro should have an argument of python3-asynctest, > not python3-mmtf. Fixed in -2 already. > * Capitalize your changelog entry. Why? The changelog entries are not sentences. > * Instead of using the working directory for the tests, use the buildroot's > sitelib by setting PYTHONPATH to %{buildroot}%{python3_sitelib}. Done. https://rathann.fedorapeople.org/review/python-asynctest/python-asynctest.spec https://rathann.fedorapeople.org/review/python-asynctest/python-asynctest-0.12.2-3.fc30.src.rpm * Mon Jan 14 2019 Dominik Mierzejewski <dominik@xxxxxxxxxxxxxx> 0.12.2-3 - remove trailing space from description - rename pname to standard pypi_name and use pypi_source macro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
