[Bug 1664399] Review Request: mp3gain - Lossless MP3 volume adjustment tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1664399



--- Comment #3 from Xavier Bachelot <xavier@xxxxxxxxxxxx> ---
Thanks to Andrea's comment, I noticed I missed another nit-pick ;-)
- Replace %define by %global

An alternative to sed would be to use tr :
%global tarball_version %(echo %version | tr _ .)

In any case, you need to either BR: coreutils (for tr) or BR: sed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux