https://bugzilla.redhat.com/show_bug.cgi?id=1664399 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx --- Comment #1 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- >From a cursory glance, the spec looks generally clean. A couple comments though: - Drop Group: tag - Add comments for Source1, Source2 and Patch2 explaining where they come from. - Does the manpage need to be pre-compressed ? The build could handle the compression and thus the .gz suffix can be replaced by a wildcard in %files in case the compression method changes someday. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
