https://bugzilla.redhat.com/show_bug.cgi?id=1659709 --- Comment #7 from Andrew Bauer <zonexpertconsulting@xxxxxxxxxxx> --- (In reply to Nikola Forró from comment #6) > I don't think those warnings are serious, but it would be nice to fix them. > It's not a review blocker though. > Done. My anal retentive side took over and I fixed all the warnings that were appearing in the build output. PR sent to unofficial upstream repository: https://github.com/matthiasbock/dymo-cups-drivers/pull/7 > There are two license files, LICENSE and COPYING, that are identical except > for whitespace differences. I don't think it's necessary to package both of > them. Done. > > /usr/lib/cups/filter, /usr/share/cups and /usr/share/cups/model directories > are owned by cups-filesystem, so this package shouldn't own them. > This should do the trick: > > %files > ... > %{_cups_serverbin}/filter/* > %{_datadir}/cups/model/* > Done. Updated Spec URL: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/dymo-cups-drivers.spec Updated Source RPM: https://copr-be.cloud.fedoraproject.org/results/kni/DymoCupsDrivers/fedora-rawhide-x86_64/00843016-dymo-cups-drivers/dymo-cups-drivers-1.4.0.5-4.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
