[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1659709



--- Comment #6 from Nikola Forró <nforro@xxxxxxxxxx> ---
I don't think those warnings are serious, but it would be nice to fix them.
It's not a review blocker though.

There are two license files, LICENSE and COPYING, that are identical except for
whitespace differences. I don't think it's necessary to package both of them.

/usr/lib/cups/filter, /usr/share/cups and /usr/share/cups/model directories are
owned by cups-filesystem, so this package shouldn't own them.
This should do the trick:

%files
...
%{_cups_serverbin}/filter/*
%{_datadir}/cups/model/*

Otherwise I believe the package is fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux