https://bugzilla.redhat.com/show_bug.cgi?id=1663618 --- Comment #3 from Richard Fearn <richardfearn@xxxxxxxxx> --- Many thanks for the quick review, Jitka! Is there a tool you used to find the missing dependencies? > BuildRequires > FIX: Please add following BRs > - perl(charnames) - lib/App/ccdiff.pm:7 > - perl(Getopt::Long) - lib/App/ccdiff.pm:10 > - perl(Term::ANSIColor) - lib/App/ccdiff.pm:9 > - perl(warnings) - used in Makefile.PL:2, lib/App/ccdiff.pm:6, ... > - make - spec file lines 43, 50 Done. It looked to me like the build succeeded without these dependencies, so what was the rationale for including them? I couldn't see anything relevant in the packaging guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_build_dependencies). Is it just that, since the script is being tested during the build, the BuildRequires should include all of the Requires? > FIX: Please add following deps to Requires > - perl(Pod::Usage) - ccdiff:106, lib/App/ccdiff.pm:106 > - perl-podlators - ccdiff:105, lib/App/ccdiff.pm:105 > - groff-base - ccdiff:105, lib/App/ccdiff.pm:105 Done. > If you want to add the package to EPEL, please ignore these two TODO > TODO: The easier way to remove .packlist is used NO_PACKLIST option, > which is part of perl(ExtUtils::MakeMaker) >= 6.76. It can be > used in all Fedoras. The command is > perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 > > TODO: Remove the deleting empty directories in %install section. This is > default behavior for Fedoras. Ah, thanks. Both of the find commands were added automatically by `rpmdev-newspec -t perl`. I'll remove them for now, so that the spec is more appropriate for Fedora. > Please correct all 'FIX' issues and consider fixing 'TODO' items and > provide new spec file. Spec URL: https://richardfearn.fedorapeople.org/perl-App-ccdiff/perl-App-ccdiff.spec SRPM URL: https://richardfearn.fedorapeople.org/perl-App-ccdiff/perl-App-ccdiff-0.26-4.fc30.src.rpm Scratch builds: F29 https://koji.fedoraproject.org/koji/taskinfo?taskID=31881668 https://kojipkgs.fedoraproject.org//work/tasks/1669/31881669/perl-App-ccdiff-0.26-4.fc29.noarch.rpm F30 https://koji.fedoraproject.org/koji/taskinfo?taskID=31881666 https://kojipkgs.fedoraproject.org//work/tasks/1667/31881667/perl-App-ccdiff-0.26-4.fc30.noarch.rpm Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
