https://bugzilla.redhat.com/show_bug.cgi?id=1663618 --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add following BRs - perl(charnames) - lib/App/ccdiff.pm:7 - perl(Getopt::Long) - lib/App/ccdiff.pm:10 - perl(Term::ANSIColor) - lib/App/ccdiff.pm:9 - perl(warnings) - used in Makefile.PL:2, lib/App/ccdiff.pm:6, ... - make - spec file lines 43, 50 $ rpm -qp --requires perl-App-ccdiff-0.26-1.fc30.noarch.rpm | sort | uniq -c 1 perl(Algorithm::Diff) 1 perl(charnames) 1 perl(Getopt::Long) 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(Term::ANSIColor) 1 perl(:VERSION) >= 5.14.0 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 /usr/bin/perl FIX: Please add following deps to Requires - perl(Pod::Usage) - ccdiff:106, lib/App/ccdiff.pm:106 - perl-podlators - ccdiff:105, lib/App/ccdiff.pm:105 - groff-base - ccdiff:105, lib/App/ccdiff.pm:105 $ rpm -qp --provides perl-App-ccdiff-0.26-1.fc30.noarch.rpm | sort | uniq -c 1 perl(App::ccdiff) = 0.26 1 perl-App-ccdiff = 0.26-1.fc30 Binary provides are Ok. $ rpmlint ./perl-App-ccdiff* perl-App-ccdiff.noarch: W: spelling-error %description -l en_US visuably -> visually, advisably, viably perl-App-ccdiff.noarch: W: spelling-error %description -l en_US colordiff -> color diff, color-diff, colorful perl-App-ccdiff.src: W: spelling-error %description -l en_US visuably -> visually, advisably, viably perl-App-ccdiff.src: W: spelling-error %description -l en_US colordiff -> color diff, color-diff, colorful 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Rpmlint is ok If you want to add the package to EPEL, please ignore these two TODO TODO: The easier way to remove .packlist is used NO_PACKLIST option, which is part of perl(ExtUtils::MakeMaker) >= 6.76. It can be used in all Fedoras. The command is perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 TODO: Remove the deleting empty directories in %install section. This is default behavior for Fedoras. Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. The package is not approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
