https://bugzilla.redhat.com/show_bug.cgi?id=1658851 --- Comment #3 from Andrew Bauer <zonexpertconsulting@xxxxxxxxxxx> --- Thank you for the feedback. > TODO: Remove the obsolete `Group:' tag. Done. > FIX: Build-require `coreutils' (perl-Schedule-Cron.spec:57). Done. > TODO: Do not build-require `perl-devel`, it's not needed. Done. > TODO: Constrain `perl(ExtUtils::MakeMaker)' build-dependency with `>= 6.76' because of NO_PACKLIST=1 and remove `find %{buildroot} -type f -name .packlist -delete' line from the %install section. Or remove the `NO_PACKLIST=1' argument. The NO_PACKLIST flag does not cause an error condition for older MakeMaker's, but I have chosen the second option since I plan to build for epel7. Done. > FIX: Remove `find %{buildroot} -type d -empty -delete' line from the %install section. ExtUtils::MakeMaker does not create empty directories, the command is not necessary. Done. > FIX: Constrain `perl(Time::ParseDate)' build-dependency with `>= 2011.0505' (Makefile.PL:19). Done. > FIX: Build-require `perl(File::Basename)' (t/load_crontab.t:4). Done. > FIX: Build-require `perl(strict)' (t/after_job.t:7). Done. > FIX: Build-require `perl(warnings)' (t/delete_entry.t:12). Done. ...... > FIX: Build-require `perl(Data::Dumper)' (lib/Schedule/Cron.pm:65). Done. > FIX: Build-require `perl(subs)' (lib/Schedule/Cron.pm:69). Done. > FIX: Build-require `perl(vars)' (lib/Schedule/Cron.pm:68). Done. ...... > FIX: Run-require `perl(Config)' (lib/Schedule/Cron.pm:1708). Done. > FIX: Constrain `perl(Time::ParseDate)' run-dependency with `>= 2011.0505' (Makefile.PL:19). Done. > TODO: POSIX is optional, declare the optional dependency using `Suggests: perl(POSIX)'. Used Requires, rather than Suggests, for el7 compatibility. Done. > TODO: Term::ReadLine is optional, declare the optional dependency using `Suggests: perl(Term::ReadLine)'. Used Requires, rather than Suggests, for el7 compatibility. Done. Updated SPEC Url: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/perl-Schedule-Cron.spec Updated SRPM Url: https://copr-be.cloud.fedoraproject.org/results/kni/perl-Schedule-Cron/fedora-rawhide-x86_64/00837356-perl-Schedule-Cron/perl-Schedule-Cron-1.01-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
