https://bugzilla.redhat.com/show_bug.cgi?id=1658851 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source links are Ok. Source0 (SHA-256: 8212766652e098e23e1ef193b9739e9cc0ed106425cb9f8a50111877cfe02940) is original. Ok. Source1 (SHA-256: 1daafdb99cd9da730d27e66a4773e8e98d3a431a6fd3ec0ab39a056e0677bf0f) is original. Ok. Summary is Ok. Description is Ok. License verified from lib/Schedule/Cron.pm, examples/custom_sleep.pl, README, and Source1. Ok. TODO: Remove the obsolete `Group:' tag. No XS code, noarch BuildArch is Ok. FIX: Build-require `coreutils' (perl-Schedule-Cron.spec:57). TODO: Do not build-require `perl-devel`, it's not needed. TODO: Constrain `perl(ExtUtils::MakeMaker)' build-dependency with `>= 6.76' because of NO_PACKLIST=1 and remove `find %{buildroot} -type f -name .packlist -delete' line from the %install section. Or remove the `NO_PACKLIST=1' argument. FIX: Remove `find %{buildroot} -type d -empty -delete' line from the %install section. ExtUtils::MakeMaker does not create empty directories, the command is not necessary. FIX: Constrain `perl(Time::ParseDate)' build-dependency with `>= 2011.0505' (Makefile.PL:19). FIX: Build-require `perl(File::Basename)' (t/load_crontab.t:4). FIX: Build-require `perl(strict)' (t/after_job.t:7). FIX: Build-require `perl(warnings)' (t/delete_entry.t:12). Test::Kwalitee, Test::Pod, Test::Pod::Coverage, DateTime::TimeZone::Local are an optional for tests. Ok. Config and Term::ReadLine are not used at tests. Ok. FIX: Build-require `perl(Data::Dumper)' (lib/Schedule/Cron.pm:65). FIX: Build-require `perl(subs)' (lib/Schedule/Cron.pm:69). FIX: Build-require `perl(vars)' (lib/Schedule/Cron.pm:68). All tests pass. Ok. $ rpmlint perl-Schedule-Cron.spec ../SRPMS/perl-Schedule-Cron-1.01-1.fc30.src.rpm ../RPMS/noarch/perl-Schedule-Cron-1.01-1.fc30.noarch.rpm perl-Schedule-Cron.src: W: spelling-error %description -l en_US crontab -> contactable perl-Schedule-Cron.noarch: W: spelling-error %description -l en_US crontab -> contactable 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Schedule-Cron-1.01-1.fc30.noarch.rpm drwxr-xr-x 2 root root 0 Dec 14 14:40 /usr/share/doc/perl-Schedule-Cron -rw-r--r-- 1 root root 3388 Jun 6 2011 /usr/share/doc/perl-Schedule-Cron/CHANGES -rw-r--r-- 1 root root 3948 Jun 6 2011 /usr/share/doc/perl-Schedule-Cron/ChangeLog -rw-r--r-- 1 root root 5412 Jun 6 2011 /usr/share/doc/perl-Schedule-Cron/README drwxr-xr-x 2 root root 0 Jun 6 2011 /usr/share/doc/perl-Schedule-Cron/examples -rw-r--r-- 1 root root 95 Jun 6 2011 /usr/share/doc/perl-Schedule-Cron/examples/cron.tab -rw-r--r-- 1 root root 11633 Jun 6 2011 /usr/share/doc/perl-Schedule-Cron/examples/custom_sleep.pl -rw-r--r-- 1 root root 861 Jun 6 2011 /usr/share/doc/perl-Schedule-Cron/examples/simple.pl drwxr-xr-x 2 root root 0 Dec 14 14:40 /usr/share/licenses/perl-Schedule-Cron -rw-rw-r-- 1 root root 6600 Dec 14 14:10 /usr/share/licenses/perl-Schedule-Cron/Licensing.html -rw-r--r-- 1 root root 9190 Dec 14 14:40 /usr/share/man/man3/Schedule::Cron.3pm.gz drwxr-xr-x 2 root root 0 Dec 14 14:40 /usr/share/perl5/vendor_perl/Schedule -rw-r--r-- 1 root root 56146 Dec 14 14:40 /usr/share/perl5/vendor_perl/Schedule/Cron.pm File layout and permissions is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Schedule-Cron-1.01-1.fc30.noarch.rpm | sort -f | uniq -c 1 perl(Data::Dumper) 1 perl(strict) 1 perl(subs) 1 perl(Time::ParseDate) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require `perl(Config)' (lib/Schedule/Cron.pm:1708). FIX: Constrain `perl(Time::ParseDate)' run-dependency with `>= 2011.0505' (Makefile.PL:19). TODO: POSIX is optional, declare the optional dependency using `Suggests: perl(POSIX)'. TODO: Term::ReadLine is optional, declare the optional dependency using `Suggests: perl(Term::ReadLine)'. $ rpm -q --provides -p ../RPMS/noarch/perl-Schedule-Cron-1.01-1.fc30.noarch.rpm | sort -f | uniq -c 1 perl(Schedule::Cron) = 1.01 1 perl-Schedule-Cron = 1.01-1.fc30 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Schedule-Cron-1.01-1.fc30.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F30 (https://koji.fedoraproject.org/koji/taskinfo?taskID=31459631). Ok. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all `FIX' items, consider fixint `TODO' items and provide a new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
