https://bugzilla.redhat.com/show_bug.cgi?id=1654666 Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #1 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> --- > BuildRequires: python3-six > BuildRequires: python3-jsonschema > BuildRequires: python3-PyYAML Those are not needed in build-time. > Group: System Environment/Libraries Remove this. > License: GPLv2+ This is not needed in subpackage. > %license LICENSE This should be in python3 subpackage. > Requires: python3-six > Requires: python3-jsonschema > Requires: python3-PyYAML Remove this and declare %{?python_enable_dependency_generator} on top of spec. > Source0: https://github.com/%{srcname}/%{srcname}/archive/v%{version}/%{srcname}-%{version}.tar.gz You can use %{url}/archive/v%{version}/%{srcname}-%{version}.tar.gz > Recommends: NetworkManager Should that be Recommends or Suggests? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
