https://bugzilla.redhat.com/show_bug.cgi?id=1652983 --- Comment #1 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Here's the review. A few tweaks are needed, and the test should be tried to run and so on: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues ======= - Please replace the tabs with spaces (consistency is key) - Please remove the trailing spaces - Please enable tests - Please inform upstream of missing license in the pypi tarball and use the Github tar in the meantime as source. - Requires is incomplete - Please test builds with F28/F29 - Description and summaries need tweaking. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Please use the Github tarball that includes the License file and request upstream to include it in the pypi tarball. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GNU Lesser General Public License", "Unknown or generated", "*No copyright* BSD (unspecified)". 110 files have unknown license. Detailed output of licensecheck in /home/asinha/1652983 -python-chaospy/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. One file requiers sklearn which isn't mentioned in setup.py (and so the automatic dep generator does not include it---worth filing a ticket upstream): grep -rn "import" * ... src/chaospy/regression.py:161: from sklearn.linear_model.base import LinearModel [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Noted above. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: Package should compile and build into binary rpms on all supported architectures. Please test on F29/F28 [!]: %check is present and all tests pass. Tests haven't been run [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-chaospy-2.3.5-1.fc30.noarch.rpm python-chaospy-2.3.5-1.fc30.src.rpm python3-chaospy.noarch: E: summary-too-long C Chaospy is a numerical tool for performing uncertainty quantification using polynomial python3-chaospy.noarch: E: description-line-too-long C Chaospy is a numerical tool for performing uncertainty quantification using polynomial. python-chaospy.src: E: summary-too-long C Chaospy is a numerical tool for performing uncertainty quantification using polynomial This needs to be shortened. How about "Toolbox for performing uncertainty quantification" as used on the Github project page: https://github.com/jonathf/chaospy python-chaospy.src: E: description-line-too-long C Chaospy is a numerical tool for performing uncertainty quantification using polynomial. Breaking it into two lines would fix it. python-chaospy.src:34: W: mixed-use-of-spaces-and-tabs (spaces: line 16, tab: line 34) Noted above. 2 packages and 0 specfiles checked; 4 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory python3-chaospy.noarch: E: summary-too-long C Chaospy is a numerical tool for performing uncertainty quantification using polynomial python3-chaospy.noarch: E: description-line-too-long C Chaospy is a numerical tool for performing uncertainty quantification using polynomial. python3-chaospy.noarch: W: invalid-url URL: https://github.com/jonathf/chaospy <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 2 errors, 1 warnings. Requires -------- python3-chaospy (rpmlib, GLIBC filtered): python(abi) python3-networkx python3-numpy python3-scipy Provides -------- python3-chaospy: python3-chaospy python3.7dist(chaospy) python3dist(chaospy) Source checksums ---------------- https://files.pythonhosted.org/packages/source/c/chaospy/chaospy-2.3.5.tar.gz : CHECKSUM(SHA256) this package : 8650406e71582109831e959d8470b828f93d79235d03a5c75bbeac979526eaa2 CHECKSUM(SHA256) upstream package : 8650406e71582109831e959d8470b828f93d79235d03a5c75bbeac979526eaa2 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1652983 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
