https://bugzilla.redhat.com/show_bug.cgi?id=1652976 --- Comment #1 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Here's the review. Needs a few improvements: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues ======= - License field should be updated - If you use the github tar, it contains the LICENSE, examples, and docs. Maybe file a ticket upstream to request them to include the license in the Pypi tarball, but use the Github tarball in the meantime? - Please test build on F28/F29 - Please correct the rpmlint issue - Please enable tests ===== MUST items ===== Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. License should simply be BSD. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. You should either: - Add the license file from the github repo as SOURCE1: https://raw.githubusercontent.com/mne-tools/mne-bids/master/LICENSE or: - File a ticket upstream asking them to include the license, and mention this as a comment, and use the Github tar in the meantime. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* BSD (unspecified)". 9 files have unknown license. Detailed output of licensecheck in /home/asinha/1652976-python-mne-bids/licensecheck.txt License should simply be "BSD". [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. The setup.py file in the package is unfortunately incomplete: `grep -nr "import"` shows that the package needs numpy, pandas, six, shutil, scipy, json. These would get caught if the tests were run I reckon. You can submit a PR upstream or at least file an issue letting them know. Since these are not mentioned in setup.py, the automatic dep generator has also not found them and they need to be listed manually as Requires and BuildRequires: $ grep -rn "import" * bin/mne_bids:4:import sys bin/mne_bids:5:import glob bin/mne_bids:6:import subprocess bin/mne_bids:7:import os.path as op bin/mne_bids:9:import mne_bids mne_bids/pick.py:5:from mne.io.constants import FIFF mne_bids/utils.py:10:import os mne_bids/utils.py:11:import os.path as op mne_bids/utils.py:12:import re mne_bids/utils.py:13:import errno mne_bids/utils.py:14:from collections import OrderedDict mne_bids/utils.py:15:import json mne_bids/utils.py:16:import shutil as sh mne_bids/utils.py:18:import numpy as np mne_bids/utils.py:19:from scipy.io import loadmat, savemat mne_bids/utils.py:20:from mne import read_events, find_events mne_bids/utils.py:21:from mne.externals.six import string_types mne_bids/utils.py:22:from mne.channels import read_montage mne_bids/utils.py:23:from mne.io.pick import pick_types mne_bids/utils.py:25:from .config import BIDS_VERSION mne_bids/utils.py:26:from .io import _parse_ext mne_bids/commands/mne_bids_raw_to_bids.py:10:from mne_bids import write_raw_bids, make_bids_basename mne_bids/commands/mne_bids_raw_to_bids.py:11:from mne_bids.io import _read_raw mne_bids/commands/mne_bids_raw_to_bids.py:16: from mne.commands.utils import get_optparser mne_bids/io.py:9:from mne import io mne_bids/io.py:10:import os mne_bids/datasets.py:9:import os mne_bids/datasets.py:10:import os.path as op mne_bids/datasets.py:11:import shutil mne_bids/datasets.py:12:import tarfile mne_bids/datasets.py:13:from six.moves import urllib mne_bids/datasets.py:15:from mne.utils import _fetch_file mne_bids/mne_bids.py:11:import os mne_bids/mne_bids.py:12:import errno mne_bids/mne_bids.py:13:import os.path as op mne_bids/mne_bids.py:15:import shutil as sh mne_bids/mne_bids.py:16:import pandas as pd mne_bids/mne_bids.py:17:from collections import defaultdict, OrderedDict mne_bids/mne_bids.py:19:import numpy as np mne_bids/mne_bids.py:20:from numpy.testing import assert_array_equal mne_bids/mne_bids.py:22:from mne import Epochs mne_bids/mne_bids.py:23:from mne.io.constants import FIFF mne_bids/mne_bids.py:24:from mne.io.pick import channel_type mne_bids/mne_bids.py:25:from mne.io import BaseRaw mne_bids/mne_bids.py:26:from mne.channels.channels import _unit2human mne_bids/mne_bids.py:27:from mne.utils import check_version mne_bids/mne_bids.py:29:from datetime import datetime mne_bids/mne_bids.py:30:from warnings import warn mne_bids/mne_bids.py:32:from .pick import coil_type mne_bids/mne_bids.py:33:from .utils import (make_bids_basename, make_bids_folders, mne_bids/mne_bids.py:39:from .io import _parse_ext, ALLOWED_EXTENSIONS, reader mne_bids/__init__.py:6:from .mne_bids import write_raw_bids # noqa mne_bids/__init__.py:7:from .utils import make_bids_folders, make_bids_basename # noqa mne_bids/__init__.py:8:from .config import BIDS_VERSION # noqa mne_bids.egg-info/PKG-INFO:42: $ python -c 'import mne_bids' mne_bids.egg-info/PKG-INFO:49: In addition to `import mne_bids`, you can use the command line interface. PKG-INFO:42: $ python -c 'import mne_bids' PKG-INFO:49: In addition to `import mne_bids`, you can use the command line interface. README.md:33: $ python -c 'import mne_bids' README.md:40:In addition to `import mne_bids`, you can use the command line interface. setup.py:2:from setuptools import setup, find_packages [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. As noted above. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. Please double check that it builds on F29/F28. It builds properly on rawhide, but F28/29 are where we have both py2 and py3. [!]: %check is present and all tests pass. The tests havent been run. Please change the bcond_with to bcond_without to enable them: http://rpm.org/user_doc/conditional_builds.html [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-mne-bids-0.1-1.fc30.noarch.rpm python-mne-bids-0.1-1.fc30.src.rpm python3-mne-bids.noarch: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases python3-mne-bids.noarch: W: invalid-license 3-clause Noted above. python3-mne-bids.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/mne_bids/commands/mne_bids_raw_to_bids.py /usr/bin/env python ^ This needs to be corrected by deleting the unneeded shebang with something like this: sed -i '/\/usr\/bin\/env python/ d' <file> python3-mne-bids.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/mne_bids/commands/mne_bids_raw_to_bids.py 644 /usr/bin/env python ^ This will be corrected if the shebang is removed. python3-mne-bids.noarch: W: no-manual-page-for-binary mne_bids python-mne-bids.src: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases python-mne-bids.src: W: invalid-license 3-clause 2 packages and 0 specfiles checked; 2 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory python3-mne-bids.noarch: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases python3-mne-bids.noarch: W: invalid-license 3-clause python3-mne-bids.noarch: W: invalid-url URL: https://mne-tools.github.io/mne-bids/ <urlopen error [Errno -2] Name or service not known> python3-mne-bids.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/mne_bids/commands/mne_bids_raw_to_bids.py /usr/bin/env python python3-mne-bids.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/mne_bids/commands/mne_bids_raw_to_bids.py 644 /usr/bin/env python ^ Noted above. python3-mne-bids.noarch: W: no-manual-page-for-binary mne_bids 1 packages and 0 specfiles checked; 2 errors, 4 warnings. Requires -------- python3-mne-bids (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) Provides -------- python3-mne-bids: python3-mne-bids python3.7dist(mne-bids) python3dist(mne-bids) Source checksums ---------------- https://files.pythonhosted.org/packages/source/m/mne-bids/mne-bids-0.1.tar.gz : CHECKSUM(SHA256) this package : 402524ef5c3aa466e601dca078ee2c379ebd0a8ba4d20792cf390e240fe47d37 CHECKSUM(SHA256) upstream package : 402524ef5c3aa466e601dca078ee2c379ebd0a8ba4d20792cf390e240fe47d37 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1652976 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
