https://bugzilla.redhat.com/show_bug.cgi?id=1649576 --- Comment #6 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> --- (In reply to Jie Kang from comment #5) > The package will need to have a runtime dependency on dd-plist and xz-java > as it does not include the packages in the jar it builds. It looks like the > rpm build system adds the requires automatically but I think it's best to > specify it explicitly. I disagree, sorry. The build generates this: Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: java-headless >= 1:1.7 javapackages-filesystem mvn(com.googlecode.plist:dd-plist) mvn(org.tukaani:xz) Then in a mock with xz-java and dd-plist installed I see: <mock-chroot> sh-4.4# rpm -q --whatprovides 'mvn(org.tukaani:xz)' xz-java-1.8-3.fc29.noarch <mock-chroot> sh-4.4# rpm -q --whatprovides 'mvn(com.googlecode.plist:dd-plist)' dd-plist-1.21-1.fc30.noarch Listing it explicitly will have the requirements in place twice and clutters the spec file. Perhaps adding a comment that requirements will get generated by the maven requires generator is enough? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
