https://bugzilla.redhat.com/show_bug.cgi?id=1646795 --- Comment #7 from Michael DePaulo <mikedep333@xxxxxxxxx> --- > Anyhow, I think specifying %doc here is not needed as files are already in pkgdocdir: > > %doc %{_pkgdocdir}/*/example-*-playbook.yml > %doc %{_pkgdocdir}/network/example-inventory > %doc %{_pkgdocdir}/timesync/example-multiple-ntp-servers.yml > %doc %{_pkgdocdir}/timesync/example-single-pool.yml > %doc %{_pkgdocdir}/*/README.md > %doc %{_pkgdocdir}/*/README.html You're right. `rpm -qd` indicates it is not necessary. I updated the spec file in git. (See the same URL) > Also these are already in _pkgdocdir, so I don't thenk it is necessary to specix them a second time: > > %doc %{_datadir}/ansible/roles/%{roleprefix}kdump/README.md > %doc %{_datadir}/ansible/roles/%{roleprefix}postfix/README.md > %doc %{_datadir}/ansible/roles/%{roleprefix}selinux/README.md > %doc %{_datadir}/ansible/roles/%{roleprefix}timesync/README.md > %doc %{_datadir}/ansible/roles/%{roleprefix}network/README.md > %doc %{_datadir}/ansible/roles/%{roleprefix}kdump/README.html > %doc %{_datadir}/ansible/roles/%{roleprefix}postfix/README.html > %doc %{_datadir}/ansible/roles/%{roleprefix}selinux/README.html > %doc %{_datadir}/ansible/roles/%{roleprefix}timesync/README.html > %doc %{_datadir}/ansible/roles/%{roleprefix}network/README.html We need to specify them a 2nd time for them to be considered documentation files under _datadir though. I still offer to make the _pkgdocdir files symlinks to the the files under _datadir. Same thing for the licenses. > Instead of COPYING LICERSE and COPYING to pkgdocdir, copy them instead to licensedir: > ... Agreed and implemented also. `rpm -qL` indicates that I still need to specify %license > Trx to fix rpmlint error by removing shebangs: > [...] The design of Ansible is that the "Ansible modules" (scripts in "library", etc) never get executed on the management node (where linux-system-roles gets installed.) Instead, Ansible at runtime copies them (via SSH) to the managed nodes, where it changes the permissions and executes them according to the shebang. So the files need to have functional shebangs, but should be non-executable on the disk where the RPM is installed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
