[Bug 1646795] Review Request: linux-system-roles - Set of interfaces for unified system management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1646795



--- Comment #6 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
I couldn't find anymore info on this.

Anyhow, I think specifying %doc here is not needed as files are already in
pkgdocdir:

%doc %{_pkgdocdir}/*/example-*-playbook.yml
%doc %{_pkgdocdir}/network/example-inventory
%doc %{_pkgdocdir}/timesync/example-multiple-ntp-servers.yml
%doc %{_pkgdocdir}/timesync/example-single-pool.yml
%doc %{_pkgdocdir}/*/README.md
%doc %{_pkgdocdir}/*/README.html


Also these are already in _pkgdocdir, so I don't thenk it is necessary to
specix them a second time:

%doc %{_datadir}/ansible/roles/%{roleprefix}kdump/README.md
%doc %{_datadir}/ansible/roles/%{roleprefix}postfix/README.md
%doc %{_datadir}/ansible/roles/%{roleprefix}selinux/README.md
%doc %{_datadir}/ansible/roles/%{roleprefix}timesync/README.md
%doc %{_datadir}/ansible/roles/%{roleprefix}network/README.md
%doc %{_datadir}/ansible/roles/%{roleprefix}kdump/README.html
%doc %{_datadir}/ansible/roles/%{roleprefix}postfix/README.html
%doc %{_datadir}/ansible/roles/%{roleprefix}selinux/README.html
%doc %{_datadir}/ansible/roles/%{roleprefix}timesync/README.html
%doc %{_datadir}/ansible/roles/%{roleprefix}network/README.html


Instead of COPYING LICERSE and COPYING to pkgdocdir, copy them instead to
licensedir:

cp -p $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}kdump/README.md \
    $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}kdump/README.html \
    $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}kdump/COPYING \
    $RPM_BUILD_ROOT%{_pkgdocdir}/kdump

cp -p $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}postfix/README.md \
    $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}postfix/README.html \
    $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}postfix/COPYING \
    $RPM_BUILD_ROOT%{_pkgdocdir}/postfix

cp -p $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}selinux/README.md \
    $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}selinux/README.html \
    $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}selinux/COPYING \
    $RPM_BUILD_ROOT%{_pkgdocdir}/selinux
mv
$RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}selinux/selinux-playbook.yml
\
    $RPM_BUILD_ROOT%{_pkgdocdir}/selinux/example-selinux-playbook.yml

cp -p $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}timesync/README.md
\
    $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}timesync/README.html
\
    $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}timesync/COPYING \
    $RPM_BUILD_ROOT%{_pkgdocdir}/timesync

cp -p $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}network/README.md \
    $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}network/README.html \
    $RPM_BUILD_ROOT%{_datadir}/ansible/roles/%{roleprefix}network/LICENSE \
    $RPM_BUILD_ROOT%{_pkgdocdir}/network

wOwn these directorx 

[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/doc/linux-system-roles/kdump,
     /usr/share/doc/linux-system-roles/network, /usr/share/doc/linux-
     system-roles/postfix, /usr/share/doc/linux-system-roles/selinux,
     /usr/share/doc/linux-system-roles, /usr/share/doc/linux-system-
     roles/timesync

Trx to fix rpmlint error by removing shebangs:

linux-system-roles.noarch: W: hidden-file-or-dir
/usr/share/ansible/roles/linux-system-roles.network/.travis.yml
linux-system-roles.noarch: E: non-executable-script
/usr/share/ansible/roles/linux-system-roles.network/library/network_connections.py
644 /usr/bin/python 
linux-system-roles.noarch: E: non-executable-script
/usr/share/ansible/roles/linux-system-roles.network/module_utils/network_lsr/__init__.py
644 /usr/bin/python3 -tt
linux-system-roles.noarch: E: non-executable-script
/usr/share/ansible/roles/linux-system-roles.network/module_utils/network_lsr/argument_validator.py
644 /usr/bin/python3 -tt
linux-system-roles.noarch: E: non-executable-script
/usr/share/ansible/roles/linux-system-roles.network/module_utils/network_lsr/utils.py
644 /usr/bin/python3 -tt
linux-system-roles.noarch: E: wrong-script-interpreter
/usr/share/ansible/roles/linux-system-roles.network/tests/test_network_connections.py
/usr/bin/env python
linux-system-roles.noarch: E: non-executable-script
/usr/share/ansible/roles/linux-system-roles.network/tests/test_network_connections.py
644 /usr/bin/env python
linux-system-roles.noarch: E: non-executable-script
/usr/share/ansible/roles/linux-system-roles.selinux/library/selogin.py 644
/usr/bin/python 
linux-system-roles.noarch: E: non-executable-script
/usr/share/ansible/roles/linux-system-roles.timesync/library/timesync_provider.sh
644 /bin/bash

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux