https://bugzilla.redhat.com/show_bug.cgi?id=1441843 --- Comment #32 from Jonathan Dieter <jdieter@xxxxxxxxx> --- The issues that still need to be resolved: [!]: License field in the package spec file matches the actual license. License should be GPLv3+ and BSD [!]: Requires correct, justified where necessary. The comment below indicates that these requirements might belong to the linchpin-doc subpackage? If so, they need to be listed as requirements for the subpackage, not the primary package # Extra sub-package includes Requires: beaker-client Requires: python3-libvirt Requires: python3-lxml [!]: Avoid bundling fonts in non-fonts packages. Note: linchpin-doc contains font files. If it's possible to add them as dependencies instead, we really should [!]: If you build a python module you should use the %python_provide macro I'm not completely clear if this is meant to be imported by other programs, but, if so, we should be using %python_provide [!]: Package functions as described. When I run linchpin, the following happens: $ linchpin Traceback (most recent call last): File "/usr/bin/linchpin", line 11, in <module> load_entry_point('linchpin==1.6.4', 'console_scripts', 'linchpin')() File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 484, in load_entry_point return get_distribution(dist).load_entry_point(group, name) File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2714, in load_entry_point return ep.load() File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2332, in load return self.resolve() File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2338, in resolve module = __import__(self.module_name, fromlist=['__name__'], level=0) File "/usr/lib/python3.7/site-packages/linchpin/shell/__init__.py", line 12, in <module> from linchpin.cli import LinchpinCli File "/usr/lib/python3.7/site-packages/linchpin/cli/__init__.py", line 16, in <module> from linchpin.fetch import FETCH_CLASS File "/usr/lib/python3.7/site-packages/linchpin/fetch/__init__.py", line 1, in <module> from fetch_local import FetchLocal ModuleNotFoundError: No module named 'fetch_local' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
