https://bugzilla.redhat.com/show_bug.cgi?id=1441843 --- Comment #31 from Jonathan Dieter <jdieter@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Issues: [!]: License field in the package spec file matches the actual license. License should be GPLv3+ and BSD [!]: Requires correct, justified where necessary. The comment below indicates that these requirements might belong to the linchpin-doc subpackage? If so, they need to be listed as requirements for the subpackage, not the primary package # Extra sub-package includes Requires: beaker-client Requires: python3-libvirt Requires: python3-lxml Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Issues: [!]: Avoid bundling fonts in non-fonts packages. Note: linchpin-doc contains font files. If it's possible to add them as dependencies instead, we really should [!]: If you build a python module you should use the %python_provide macro I'm not completely clear if this is meant to be imported by other programs, but, if so, we should be using %python_provide [!]: Package functions as described. When I run linchpin, the following happens: $ linchpin Traceback (most recent call last): File "/usr/bin/linchpin", line 11, in <module> load_entry_point('linchpin==1.6.4', 'console_scripts', 'linchpin')() File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 484, in load_entry_point return get_distribution(dist).load_entry_point(group, name) File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2714, in load_entry_point return ep.load() File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2332, in load return self.resolve() File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2338, in resolve module = __import__(self.module_name, fromlist=['__name__'], level=0) File "/usr/lib/python3.7/site-packages/linchpin/shell/__init__.py", line 12, in <module> from linchpin.cli import LinchpinCli File "/usr/lib/python3.7/site-packages/linchpin/cli/__init__.py", line 16, in <module> from linchpin.fetch import FETCH_CLASS File "/usr/lib/python3.7/site-packages/linchpin/fetch/__init__.py", line 1, in <module> from fetch_local import FetchLocal ModuleNotFoundError: No module named 'fetch_local' Generic: [-]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: linchpin-1.6.4-2.fc30.noarch.rpm linchpin-doc-1.6.4-2.fc30.noarch.rpm linchpin-1.6.4-2.fc30.src.rpm linchpin.noarch: W: spelling-error Summary(en_US) Ansible -> Expansible, Sensible linchpin.noarch: W: spelling-error Summary(en_US) multicloud -> multicolored linchpin.noarch: W: spelling-error Summary(en_US) orchestrator -> orchestra tor, orchestra-tor, orchestrate linchpin.noarch: E: zero-length /usr/lib/python3.7/site-packages/linchpin/defaults/layouts/README.rst linchpin.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/linchpin/provision/roles/libvirt/templates/virt_customize_user_creation.sh.j2 644 /bin/sh linchpin.noarch: W: no-manual-page-for-binary linchpin linchpin.src: W: spelling-error Summary(en_US) Ansible -> Expansible, Sensible linchpin.src: W: spelling-error Summary(en_US) multicloud -> multicolored linchpin.src: W: spelling-error Summary(en_US) orchestrator -> orchestra tor, orchestra-tor, orchestrate 3 packages and 0 specfiles checked; 2 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory linchpin-doc.noarch: W: invalid-url URL: http://github.com/CentOS-PaaS-SIG/linch-pin <urlopen error [Errno -2] Name or service not known> linchpin.noarch: W: spelling-error Summary(en_US) Ansible -> Expansible, Sensible linchpin.noarch: W: spelling-error Summary(en_US) multicloud -> multicolored linchpin.noarch: W: spelling-error Summary(en_US) orchestrator -> orchestra tor, orchestra-tor, orchestrate linchpin.noarch: W: invalid-url URL: http://github.com/CentOS-PaaS-SIG/linch-pin <urlopen error [Errno -2] Name or service not known> linchpin.noarch: E: zero-length /usr/lib/python3.7/site-packages/linchpin/defaults/layouts/README.rst linchpin.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/linchpin/provision/roles/libvirt/templates/virt_customize_user_creation.sh.j2 644 /bin/sh linchpin.noarch: W: no-manual-page-for-binary linchpin 2 packages and 0 specfiles checked; 2 errors, 6 warnings. Requires -------- linchpin-doc (rpmlib, GLIBC filtered): linchpin linchpin (rpmlib, GLIBC filtered): /usr/bin/python3 ansible beaker-client python(abi) python3-Naked python3-boto python3-cerberus python3-click python3-libcloud python3-libvirt python3-lxml python3-pyOpenSSL python3-pyyaml python3-requests python3-shade python3-six python3-tinydb python3-yamlordereddictloader Provides -------- linchpin-doc: linchpin-doc linchpin: linchpin python3.7dist(linchpin) python3dist(linchpin) Source checksums ---------------- https://github.com/CentOS-PaaS-SIG/linch-pin/archive/v1.6.4.tar.gz : CHECKSUM(SHA256) this package : 74c33ef24dc3f537debc0b8e7de1e6e0ef1c7959ba27199a4f1bc1b2860051db CHECKSUM(SHA256) upstream package : 74c33ef24dc3f537debc0b8e7de1e6e0ef1c7959ba27199a4f1bc1b2860051db -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
