Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: boxes - Draw any kind of box around some given text https://bugzilla.redhat.com/show_bug.cgi?id=292121 ------- Additional Comments From thomas.moschny@xxxxxx 2007-09-18 15:17 EST ------- Note: This is NOT a formal review (as I am not a reviewer). [x] package meets naming guidelines [x] specfile is encoded in ascii or utf-8 [x] specfile matches base package name [!] specfile uses macros consistently - use %{_bindir} in %install - maybe use a macro for the value of GLOBALCONF, because this is used twice [x] specfile is written cleanly [!] specfile is written in AE contains non-english comments [x] changelog is present and has correct format [x] license matches actual license [x] license is open source-compatible [x] license text is included in package [x] source tag has correct url [x] source files match upstream md5sum: d2ef9fa28a87bf32b3fe0c47ab82fa97 [x] latest version is packaged [x] summary is concise [x] dist tag is present [x] buildroot is correct [x] buildroot is prepped [x] %clean is present [x] proper build requirements [x] proper requirements [!] uses %{?_smp_mflags} [!] uses %{optflags} possibly requires patching the Makefile [x] doesn't use %makeinstall [x] package builds at least on one architecture tested on: fc7 x86_64 [!] packages installs and runs at least on one architecture boxes fails on fc7 x86_64 with: boxes: Alleged system-wide config file '/usr/share/boxes' is a directory [!] rpmlint is quiet boxes.src:26: W: setup-not-quiet boxes.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 8) [x] final provides/requires look sane [-] ldconfig called in %post and %postun if required [x] code, not content [x] file permissions are appropriate [!] debuginfo package looks usable the debuginfo package is empty, because -g is missing in CFLAGS, see above [-] config files marked as %config(noreplace) [x] owns all directories it creates [-] static libraries in -devel subpackage [-] header files in -devel subpackage [-] development .so files in -devel subpackage [-] pkgconfig files in -devel subpackage, requires pkgconfig [x] no .la files [x] doesn't need a -docs subpackage [x] relevant docs are included [x] doc files are not needed at runtime [-] provides a .desktop file, build-requires desktop-file-utils [-] uses %find_lang, build-requires gettext Additional notes / suggestions: - consider packaging doc/boxes.el (to ${datadir}/%{name}) - use install -p to preserve timestamps - default permissions for directories are not set in %defattr - use wildcard: %{_mandir}/man1/boxes.1* -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review