Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ladspa-blop-plugins - Bandlimited LADSPA Oscillator Plugins https://bugzilla.redhat.com/show_bug.cgi?id=292351 ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-09-18 15:09 EST ------- (In reply to comment #1) > * RPM %optflags are ignored completely. -g is missing, too. > Instead, -O3 -funroll-loops ... are used which don't guarantee > a significant performance gain. > Ah, my bad I assume that becaused the project used autotools that the optflags would just be there, fixed now. > * According to the Makefile some other files are built with > -O0 as -O1 would break some of the code. (interesting that the > authors haven't added a test suite for that) > Hmm, very interesting. This was probably caused by there use of some obscure -ffoo options, and this was determined long ago with a much older gcc. However as you said, there is no test case, so I've just left this as is to be on the safe side. > * Hint: Deleting files from the extracted tarball in the > %install section breaks --short-circuit rpmbuild. Preferably, > this is avoided when it takes only minimal effort to do so. > Fixed (and saved 100kb of installed space) Here is a new version: Spec URL: http://people.atrpms.net/~hdegoede/ladspa-blop-plugins.spec SRPM URL: http://people.atrpms.net/~hdegoede/ladspa-blop-plugins-0.2.8-4.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review