https://bugzilla.redhat.com/show_bug.cgi?id=1638968 --- Comment #10 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Thanks for the review, Antonio. (In reply to Antonio Trande from comment #9) > Issues: > ======= > - MPI compilers are not used I double checked. They are. The mpi compilers are wrapper scripts that invoke gcc while using the required flags: $ mpicc --help # gives gcc help $ mpicc -show gcc -m64 -O2 -fPIC -Wl,-z,noexecstack -I/usr/include/mpich-x86_64 -L/usr/lib64/mpich/lib -Wl,-rpath -Wl,/usr/lib64/mpich/lib -Wl,--enable-new-dtags -lmpi Autotools sets it all up for us correctly. > > - Package should not use obsolete m4 macros > Note: Some obsoleted macros found, see the attachment. > See: https://fedorahosted.org/FedoraReview/wiki/AutoTools I've filed an issue upstream, and added a comment in the spec: https://github.com/INCF/libneurosim/issues/11 The FedoraReview wiki page is missing, since fedorahosted is no more. I haven't been able to find any other information, unfortunately. https://pagure.io/FedoraReview/issue/309 > > - Python libraries are not installed into appropriate directories > (under pythonX-sitearch) I've corrected this. Also submitted a PR upstream: https://github.com/INCF/libneurosim/pull/14 > - Please, fix the 'incoherent-version-in-changelog' warning Done. Here's a scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30456134 Spec/srpm: https://ankursinha.fedorapeople.org/libneurosim/libneurosim.spec https://ankursinha.fedorapeople.org/libneurosim/libneurosim-0-1.20181025.git7d074da.fc29.src.rpm Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
