https://bugzilla.redhat.com/show_bug.cgi?id=1636111 --- Comment #13 from Kefu Chai <kchai@xxxxxxxxxx> --- (In reply to mati86dl from comment #12) > > - could you justify why debug_package is disabled? > > If remove them just result on: > > Empty %files file /home/matias/Desarrollo/rpmbuild/BUILD/glyr/debugsourcefiles.list > > ..and honestly I can not find how to fix it. You can help me.? :disapointed: sure. please see https://github.com/sahib/glyr/blob/458f31838a7db1744b4ad0dfcd8433c92eee71f9/CMakeLists.txt#L63 by default, it use "release" for its CMAKE_BUILD_TYPE, so no debug symbol is added. probably you could pass -DCMAKE_BUILD_TYPE=RelWithDebInfo and try again? > > > - could you link 0001-use-lastfm-getinfo-instead-getimages.patch to upstream bugs/comments/lists, > > or justify it in the header of the patch? > > Done. Just remove that. They were internal tests to try to solve a bug in > libclastfm. Both libclastfm an libglyr in Pragha use queries in parallel > with different private keys, then try to differentiate them. > > > - libglyr comes with a test suite, shall we have %check for exercising it and for making sure all > > tests pass? at least, capi could be tested, i guess. > > Well, check_api and check_dbc its ok, but check_opt fail.. > So, change '%{cmake}' to '%{cmake} -DTEST=true' to enable build test and > append these: > > > %check > > > bin/check_api > > > bin/check_dbc > > > # This check fails so ignore that. > > > # bin/check_opt is this expected? does the upstream have an issue tracking this? i cannot find it in https://github.com/sahib/glyr/issues though. > > It's ok? > > > - "Requires: libcurl" does not look right. please leave it to rpm, it is able to figure out > > the runtime dependency introduced by linked shared libraries. > > You are right. Also sqlite3. > > > - If your application is a C or C++ application you must list a > > BuildRequires against gcc, gcc-c++ or clang. > > Note: No gcc, gcc-c++ or clang found in BuildRequires > > See: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B > > Done.. Is half strange to specify a particular compiler, but done. > BuildRequires: gcc yeah =) guess GCC is the de factor standard in the foreseeable future on GNU/Linux. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
