https://bugzilla.redhat.com/show_bug.cgi?id=1638968 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominik@xxxxxxxxxxxxxx --- Comment #4 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- %global with_mpich 1 %global with_openmpi 1 Why do you need those at all? Is mpich or openmpi missing on some arch? If yes, just exclude the affected subpackage on that arch. # Empty debugsources.list---not sure what to do about this # gdb-add-index: No index was created for all created libraries # Needs investigation at upstream level Are Fedora build flags applied to all compiler and linker invocations? %{_libdir}/libpy3neurosim*.so.* This is forbidden now (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files). You must list shared libraries with explicit version so that you don't accidentally introduce (possibly) incompatible SONAME bumps when doing an update. %files mpich %license COPYING %doc README.md Arguably, it's better to split out common license files and documentation into a separate -common/-doc subpackage. Both -mpich and -openmpi could be installed in at the same time, duplicating some files. Finally, the %build section could be factorized by not using %{_mpich_load} and %{_openmpi_load} macros, which make it difficult. See my elpa package for example: https://src.fedoraproject.org/rpms/elpa/blob/master/f/elpa.spec#_167 . -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
