https://bugzilla.redhat.com/show_bug.cgi?id=1635422 --- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to Jerry James from comment #2) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > Issues: > ======= > - A number of files named metadata.desktop are installed. These do appear to > be regular desktop files, so should probably be checked with > desktop-file-validate. > Reading them, I don't think they are regular .desktop files, but plugins ones. > - Regarding licenses: > o wallpapers/Arc/LICENSE: Looks to be CC-BY-SA > o wallpapers/Arc-Dark/LICENSE: Ditto > > Neither of those LICENSE files is installed with the wallpapers subpackage. > Also, the CC-BY-SA license tag apparently refers to version 3.0, but this > license is 4.0. It may be necessary to inquire on fedora-legal-list > whether > CC-BY-SA also applies to 4.0, or whether a new tag is needed. > Added a License field per subpackage and added CC-BY-SA. Version 4.0 is Free according to the FSF: https://www.fsf.org/blogs/licensing/cc-by-4-0-and-cc-by-sa-4-0-added-to-our-list-of-free-licenses Should be good for us. > - Also, the main LICENSE file only appears in the main package, but the other > subpackages do not require the main package, so it is possible to install > some and not get the LICENSE file installed. > I've added license files for each subpackage. > - See the comment below about owning directories that are already owned by > other packages. Is that correct, or should contents of those directories > be > owned, rather than the directories themselves? > I've restricted the directories owned in %files. Spec URL: https://eclipseo.fedorapeople.org/arc-kde.spec SRPM URL: https://eclipseo.fedorapeople.org/arc-kde-20180614-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
