https://bugzilla.redhat.com/show_bug.cgi?id=1635422 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - A number of files named metadata.desktop are installed. These do appear to be regular desktop files, so should probably be checked with desktop-file-validate. - Regarding licenses: o wallpapers/Arc/LICENSE: Looks to be CC-BY-SA o wallpapers/Arc-Dark/LICENSE: Ditto Neither of those LICENSE files is installed with the wallpapers subpackage. Also, the CC-BY-SA license tag apparently refers to version 3.0, but this license is 4.0. It may be necessary to inquire on fedora-legal-list whether CC-BY-SA also applies to 4.0, or whether a new tag is needed. - Also, the main LICENSE file only appears in the main package, but the other subpackages do not require the main package, so it is possible to install some and not get the LICENSE file installed. - See the comment below about owning directories that are already owned by other packages. Is that correct, or should contents of those directories be owned, rather than the directories themselves? ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "CC by-sa (v4.0)", "Unknown or generated", "*No copyright* CC by-sa (v4.0)". 363 files have unknown license. [!]: License file installed when any subpackage combination is installed. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/color-schemes (plasma-desktop), /usr/share/konsole(konsole5-part), /usr/share/wallpapers(desktop-backgrounds-basic, kde-filesystem), /usr/share/plasma/desktoptheme(kf5-plasma, f26-backgrounds-kde, f28 -backgrounds-kde, f25-backgrounds-kde, f27-backgrounds-kde, plasma- desktop), /usr/share/yakuake(yakuake), /usr/share/plasma/look-and-feel (plasma-workspace), /usr/share/plasma(f27-backgrounds-kde, f26 -backgrounds-kde, kf5-plasma, f28-backgrounds-kde, f25-backgrounds- kde), /usr/share/konversation(konversation), /usr/share/konversation/themes(konversation), /usr/share/yakuake/skins(yakuake) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in arc-kde- kvantum , arc-kde-decorations , arc-kde-konsole , arc-kde-konversation , arc-kde-wallpapers , arc-kde-yakuake [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. Honestly, though, I have no idea what tests you could run. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: arc-kde-20180614-1.fc30.noarch.rpm arc-kde-kvantum-20180614-1.fc30.noarch.rpm arc-kde-decorations-20180614-1.fc30.noarch.rpm arc-kde-konsole-20180614-1.fc30.noarch.rpm arc-kde-konversation-20180614-1.fc30.noarch.rpm arc-kde-wallpapers-20180614-1.fc30.noarch.rpm arc-kde-yakuake-20180614-1.fc30.noarch.rpm arc-kde-20180614-1.fc30.src.rpm arc-kde-kvantum.noarch: W: spelling-error %description -l en_US ard -> rad, ad, rd arc-kde-kvantum.noarch: W: no-documentation arc-kde-decorations.noarch: W: no-documentation arc-kde-konsole.noarch: W: no-documentation arc-kde-konversation.noarch: W: no-documentation arc-kde-wallpapers.noarch: W: no-documentation arc-kde-yakuake.noarch: W: no-documentation 8 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory arc-kde-konversation.noarch: W: invalid-url URL: https://github.com/PapirusDevelopmentTeam/arc-kde <urlopen error [Errno -2] Name or service not known> arc-kde-konversation.noarch: W: no-documentation arc-kde-konsole.noarch: W: invalid-url URL: https://github.com/PapirusDevelopmentTeam/arc-kde <urlopen error [Errno -2] Name or service not known> arc-kde-konsole.noarch: W: no-documentation arc-kde-kvantum.noarch: W: spelling-error %description -l en_US ard -> rad, ad, rd arc-kde-kvantum.noarch: W: invalid-url URL: https://github.com/PapirusDevelopmentTeam/arc-kde <urlopen error [Errno -2] Name or service not known> arc-kde-kvantum.noarch: W: no-documentation arc-kde.noarch: W: invalid-url URL: https://github.com/PapirusDevelopmentTeam/arc-kde <urlopen error [Errno -2] Name or service not known> arc-kde-decorations.noarch: W: invalid-url URL: https://github.com/PapirusDevelopmentTeam/arc-kde <urlopen error [Errno -2] Name or service not known> arc-kde-decorations.noarch: W: no-documentation arc-kde-wallpapers.noarch: W: invalid-url URL: https://github.com/PapirusDevelopmentTeam/arc-kde <urlopen error [Errno -2] Name or service not known> arc-kde-wallpapers.noarch: W: no-documentation arc-kde-yakuake.noarch: W: invalid-url URL: https://github.com/PapirusDevelopmentTeam/arc-kde <urlopen error [Errno -2] Name or service not known> arc-kde-yakuake.noarch: W: no-documentation 7 packages and 0 specfiles checked; 0 errors, 14 warnings. Requires -------- arc-kde-konversation (rpmlib, GLIBC filtered): arc-kde-konsole (rpmlib, GLIBC filtered): arc-kde-kvantum (rpmlib, GLIBC filtered): kvantum arc-kde (rpmlib, GLIBC filtered): arc-kde-decorations (rpmlib, GLIBC filtered): arc-kde-wallpapers (rpmlib, GLIBC filtered): arc-kde-yakuake (rpmlib, GLIBC filtered): Provides -------- arc-kde-konversation: arc-kde-konversation arc-kde-konsole: arc-kde-konsole arc-kde-kvantum: arc-kde-kvantum arc-kde: arc-kde arc-kde-decorations: arc-kde-decorations arc-kde-wallpapers: arc-kde-wallpapers arc-kde-yakuake: arc-kde-yakuake Source checksums ---------------- https://github.com/PapirusDevelopmentTeam/arc-kde/archive/20180614/arc-kde-20180614.tar.gz : CHECKSUM(SHA256) this package : 44267738b2bee20f62cc3f1c150b4eb0aa7ce79f4f5d302102f11d15ffa6de15 CHECKSUM(SHA256) upstream package : 44267738b2bee20f62cc3f1c150b4eb0aa7ce79f4f5d302102f11d15ffa6de15 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1635422 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
