https://bugzilla.redhat.com/show_bug.cgi?id=1636668 Bug ID: 1636668 Summary: Review Request: <main package name here> - <short summary here> Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: johnhford@xxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Spec URL: http://johnford.org/wxHexEditor.spec SRPM URL: http://johnford.org/wxHexEditor-0.24-1.fc28.src.rpm Description: wxHexEditor is a graphical hex editor that I like Fedora Account System Username: jhford (also have john64, but not using it any more) This is not my first package, but the first in just under 10 years. It is the first time using a new FAS account "jhford", which is what I'd rather use from now on. The docs said to include background information which might be relevant. I have worked for Mozilla on the release engineering team, the Firefox OS build team and currently on our CI platform. I have been doing peer review for software for the last 10 years. I tried to follow the various packaging docs as best as I could, but there's 5 different wiki pages to follow. I cannot find contact details for the author of the tool, so I haven't been in touch yet. There's 3 patches relating to the build system. I would like to upstream them, but they're so specific to building that they're not likely worth the effort unless the tool is packaged into Fedora. The license is slightly unclear... 5 * This program is free software; you can redistribute it and/or * 6 * modify it under the terms of the GNU General Public License * 7 * as published by the Free Software Foundation; either version 2 * 8 * of the License. I used GPLv2 because I believe that to be accurate. I'm not sure what exactly is meant here, but I will clarify with the author if I can get in contact. I don't know if it was meant as "Either the GPLv2 or later" or not, so I'd like to be safe until I can clarify with the author. There's a failure on AArch64 and Armv7hl. I think it's in the base Wx Widget library, and I haven't dug into it yet. I will attach the errors to this bug (if I can) or I will comment with their contents. Apparently, I'm supposed to file a bug for this, but I suspect that I should wait for this package to be accepted (or rejected) before doing that. I'm not sure what to do about sha256. Should I download the tarball, compute the sha256 and manually validate it in the spec file, or is having a sha256 something that the Fedora infrastructure would take care of? Here's a link to a successful Koji run: https://koji.fedoraproject.org/koji/taskinfo?taskID=30074603 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
