https://bugzilla.redhat.com/show_bug.cgi?id=1634957 --- Comment #3 from Raphael Groner <projects.rg@xxxxxxxx> --- (In reply to Miro Hrončok from comment #1) > What distros are you targeting with the spec? Rawhide and EPEL7. Maybe F29/28. > %{!?__python2: %global __python2 %__python} > %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from > distutils.sysconfig import get_python_lib; print(get_python_lib())")} > > Is not needed on EPEL (and obviously not on Fedora). OK > Also, python2-test_server is a no go for Fedora: Oh, thought python2 is disabled for the Fedora build. Will check. > The %with_pythonX_tests macros do not conditionalize test requirements. > Maybe you want to do that. OK (In reply to Miro Hrončok from comment #2) > BuildRequires: %{_bindir}/sphinx-build > %if 0%{?with_python3} > BuildRequires: python%{python3_pkgversion}-sphinx-theme-alabaster > %endif > > This cannot work together. Well, it works but needs obviously some improvment. Sphinx is built with python3 in Fedora, no? EPEL7 uses python2 but shows an issue with the theme. > %{_bindir}/sphinx-build is in python2-sphinx and the theme is python3. Orly? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
