[Bug 1611829] Review Request: swtpm - TPM 1.2 and 2 emulator for QEMU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1611829



--- Comment #14 from Stefan Berger <stefanb@xxxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #13)
>    and:
> 
> %prep
> %autosetup -n %{name}-%{gitcommit}

Cool! Thanks. I am using this now.
> 
> 
> 
>    then download the source with "spectool -g swtpm.spec"
> 
>    And don't forget to fix the changelog (20180918gitbe6b378)
> 
> 
>  - Add gcc as a BR

Done.


> 
>  - Own this directory:
> 
> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/share/swtpm


I do not know what to do about this.

>  
> 
>  - patch this by replacing the obsolete macro with LT_INIT (or do it
> upstream)

This is fixed.

>  - subpackages libs and selinux must also contain the license

Done.

> 
>  - There's an error here, you should require %{name}-libs%{?_isa}, not
> %{name}%{?_isa}
> 
> %package        devel
> Summary:        Include files for the TPM emulator's CUSE interface for
> usage by clients
> Requires: %{name}-libs%{?_isa} = %{version}-%{release}

Fixed.
> 
>  - BuildRequires: python-twisted
> 
> You must specify if you want python2-twisted or python3-twisted,
> python-twisted is deprecated. Py3 preferred as we are retiring Py2 packages.
> 
Using python2-twisted now.

>  - BuildRequires: python
> 
> Same, specify python2 or python3. Py 3 preferred if it's compatible.

python3 doesn't seem to create the symlink of python to the python3 executable.
So I have to use python2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux