https://bugzilla.redhat.com/show_bug.cgi?id=1611829 --- Comment #13 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Why not use a direct link for the tar.gz? %global gitdate 20180918 %global gitcommit be6b378487548bc197bbf9fa39a01f628839a22f %global gitshortcommit %(c=%{gitcommit}; echo ${c:0:7}) # Macros needed by SELinux %global selinuxtype targeted %global moduletype contrib %global modulename swtpm Summary: TPM Emulator Name: swtpm Version: 0.1.0 Release: 0.%{gitdate}git%{gitshortcommit}%{?dist} License: BSD Url: http://github.com/stefanberger/swtpm Source0: %url/archive/%{gitcommit}/%{name}-%{gitshortcommit}.tar.gz and: %prep %autosetup -n %{name}-%{gitcommit} then download the source with "spectool -g swtpm.spec" And don't forget to fix the changelog (20180918gitbe6b378) - Add gcc as a BR - Own this directory: [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/swtpm - patch this by replacing the obsolete macro with LT_INIT (or do it upstream) AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: swtpm-0.1.0/configure.ac:43 - subpackages libs and selinux must also contain the license - There's an error here, you should require %{name}-libs%{?_isa}, not %{name}%{?_isa} %package devel Summary: Include files for the TPM emulator's CUSE interface for usage by clients Requires: %{name}-libs%{?_isa} = %{version}-%{release} - BuildRequires: python-twisted You must specify if you want python2-twisted or python3-twisted, python-twisted is deprecated. Py3 preferred as we are retiring Py2 packages. - BuildRequires: python Same, specify python2 or python3. Py 3 preferred if it's compatible. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated", "*No copyright* BSD (unspecified)". 211 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/swtpm/review- swtpm/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/swtpm [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in swtpm- libs , swtpm-selinux , swtpm-devel , swtpm-tools , swtpm-debuginfo , swtpm-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: swtpm-0.1.0-0.20180918gitbe6b378.fc30.x86_64.rpm swtpm-libs-0.1.0-0.20180918gitbe6b378.fc30.x86_64.rpm swtpm-selinux-0.1.0-0.20180918gitbe6b378.fc30.noarch.rpm swtpm-devel-0.1.0-0.20180918gitbe6b378.fc30.x86_64.rpm swtpm-tools-0.1.0-0.20180918gitbe6b378.fc30.x86_64.rpm swtpm-debuginfo-0.1.0-0.20180918gitbe6b378.fc30.x86_64.rpm swtpm-debugsource-0.1.0-0.20180918gitbe6b378.fc30.x86_64.rpm swtpm-0.1.0-0.20180918gitbe6b378.fc30.src.rpm swtpm-libs.x86_64: W: spelling-error %description -l en_US libtpms -> libations swtpm-selinux.noarch: E: explicit-lib-dependency libselinux-utils swtpm-selinux.noarch: W: dangerous-command-in-%posttrans rm swtpm.src: W: spelling-error %description -l en_US libtpms -> libations 8 packages and 0 specfiles checked; 1 errors, 3 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
