[Bug 1478210] Review Request: openas2 - Java implementation of EDIINT AS2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1478210

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #12 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - Make use of bcond_with/%bcond_without for conditionals

 - Group: us not used in Fedora

 - Requires(post): systemd
Requires(preun): systemd
Requires(postun): systemd

→ Use %{?systemd_requires}

 - Not useful in the description:

Version 2.3.1 was released on 6th Aug 2017.

 - Build fails:

[INFO] Executed tasks
[INFO] 
[INFO] --------------------< net.sf.openas2:openas2-osgi >---------------------
[INFO] Building OpenAS2 OSGi Bundle 2.6.1                                 [4/4]
[INFO] --------------------------------[ jar ]---------------------------------
[WARNING] The POM for org.osgi:org.osgi.core:jar:4.3.1 is missing, no
dependency information available
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Skipping OpenAS2
[INFO] This project has been banned from the build due to previous failures.
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] OpenAS2 2.6.1 ...................................... SUCCESS [  0.004 s]
[INFO] OpenAS2 Server ..................................... SUCCESS [  4.686 s]
[INFO] OpenAS2 Remote ..................................... SUCCESS [  0.162 s]
[INFO] OpenAS2 OSGi Bundle 2.6.1 .......................... FAILURE [  0.009 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.278 s
[INFO] Finished at: 2018-09-16T22:47:09+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project openas2-osgi: Could not resolve
dependencies for project net.sf.openas2:openas2-osgi:jar:2.6.1: Cannot access
central (https://repo.maven.apache.org/maven2) in offline mode and the artifact
org.osgi:org.osgi.core:jar:4.3.1 has not been downloaded from it before. ->
[Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the
command
[ERROR]   mvn <goals> -rf :openas2-osgi

 → Need to add:

BuildRequires:  mvn(org.osgi:org.osgi.core)

 - openas2-server.noarch: E: dir-or-file-in-var-run /var/run/openas2

It is verboten to install hiles in /var/run

 - %attr(0750,root,openas2) %dir %{_sysconfdir}/%{name}
%attr(0640,root,openas2) %config(noreplace) %{_sysconfdir}/%{name}/*

openas2-server.noarch: E: non-standard-dir-perm /etc/openas2 750
openas2-server.noarch: W: non-standard-gid /etc/openas2/as2_certs.p12 openas2
openas2-server.noarch: E: non-readable /etc/openas2/as2_certs.p12 640
openas2-server.noarch: W: non-standard-gid /etc/openas2/commands.xml openas2
openas2-server.noarch: E: non-readable /etc/openas2/commands.xml 640
openas2-server.noarch: W: non-standard-gid /etc/openas2/config.xml openas2
openas2-server.noarch: E: non-readable /etc/openas2/config.xml 640
openas2-server.noarch: W: non-standard-gid /etc/openas2/db_ddl.sql openas2
openas2-server.noarch: E: non-readable /etc/openas2/db_ddl.sql 640
openas2-server.noarch: W: non-standard-gid /etc/openas2/emailtemplate.txt
openas2
openas2-server.noarch: E: non-readable /etc/openas2/emailtemplate.txt 640
openas2-server.noarch: W: non-standard-gid /etc/openas2/partnerships.xml
openas2
openas2-server.noarch: E: non-readable /etc/openas2/partnerships.xml 640
openas2-server.noarch: W: non-standard-gid /etc/openas2/ssl_certs.jks openas2
openas2-server.noarch: E: non-readable /etc/openas2/ssl_certs.jks 640

Perms should be 0644/0755

 - openas2-server.noarch: W: log-files-without-logrotate ['/var/log/openas2']

Install a logrotate file. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Logrotate_config_file

 - Add  aversion for theses provides:

openas2.src:97: W: unversioned-explicit-provides mvn(org.hsqldb:hsqldb)
openas2.src:99: W: unversioned-explicit-provides mvn(com.h2database:h2)
openas2.src:101: W: unversioned-explicit-provides
mvn(org.bouncycastle:bcpg-jdk15on)
openas2.src:102: W: unversioned-explicit-provides
mvn(org.bouncycastle:bcmail-jdk15on)

 - See if you can do something about this:

openas2.noarch: W: class-path-in-manifest
/usr/share/java/openas2/openas2-osgi.jar
openas2.noarch: W: class-path-in-manifest
/usr/share/java/openas2/openas2-remote.jar
openas2.noarch: W: class-path-in-manifest
/usr/share/java/openas2/openas2-server.jar

class-path-in-manifest:
The META-INF/MANIFEST.MF file in the jar contains a hardcoded Class-Path.
These entries do not work with older Java versions and even if they do work,
they are inflexible and usually cause nasty surprises.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux