https://bugzilla.redhat.com/show_bug.cgi?id=1610249 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- - Not really needed: %if 0%{?_licensedir:1} %license LICENSE %else %doc LICENSE %endif All Fedora and EPEL supports %license - Add a comment explaining what does this patch do: Patch0: 01_fix_pod.patch URL and Source addresses are Ok. Source archive (SHA-256: fcd7adbc81418d4dea3b993f4f02802d5ab7c6774b244dc5fd5115ec48cc58c2) is original. Ok. Summary verified from lib/Monkey/Patch.pm. Ok. Description verified from lib/Monkey/Patch.pm. Ok. License verified from README. Ok. No XS code, noarch BuildArch is Ok. All tests pass. Ok. $ rpmlint perl-Monkey-Patch.spec review-perl-Monkey-Patch/results/perl-Monkey-Patch-0.03-1.fc29.noarch.rpm review-perl-Monkey-Patch/results/perl-Monkey-Patch-0.03-1.fc29.src.rpm perl-Monkey-Patch.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Monkey-Patch/LICENSE 2 packages and 1 specfiles checked; 1 errors, 0 warnings $ rpm -q -lv -p perl-Monkey-Patch-0.03-1.fc29.noarch.rpm drwxr-xr-x 2 root root 0 juil. 31 17:38 /usr/share/doc/perl-Monkey-Patch -rw-r--r-- 1 root root 169 juil. 17 2010 /usr/share/doc/perl-Monkey-Patch/CHANGES -rw-r--r-- 1 root root 314 juil. 17 2010 /usr/share/doc/perl-Monkey-Patch/README drwxr-xr-x 2 root root 0 juil. 31 17:38 /usr/share/licenses/perl-Monkey-Patch -rw-r--r-- 1 root root 18249 juil. 17 2010 /usr/share/licenses/perl-Monkey-Patch/LICENSE -rw-r--r-- 1 root root 2212 juil. 31 17:37 /usr/share/man/man3/Monkey::Patch.3pm.gz -rw-r--r-- 1 root root 1317 juil. 31 17:37 /usr/share/man/man3/Monkey::Patch::Handle.3pm.gz -rw-r--r-- 1 root root 1226 juil. 31 17:37 /usr/share/man/man3/Monkey::Patch::Handle::Class.3pm.gz -rw-r--r-- 1 root root 1229 juil. 31 17:37 /usr/share/man/man3/Monkey::Patch::Handle::Object.3pm.gz drwxr-xr-x 2 root root 0 juil. 31 17:37 /usr/share/perl5/vendor_perl/Monkey drwxr-xr-x 2 root root 0 juil. 31 17:37 /usr/share/perl5/vendor_perl/Monkey/Patch -rw-r--r-- 1 root root 3418 juil. 31 17:37 /usr/share/perl5/vendor_perl/Monkey/Patch.pm drwxr-xr-x 2 root root 0 juil. 31 17:37 /usr/share/perl5/vendor_perl/Monkey/Patch/Handle -rw-r--r-- 1 root root 2971 juil. 31 17:37 /usr/share/perl5/vendor_perl/Monkey/Patch/Handle.pm -rw-r--r-- 1 root root 697 juil. 31 17:37 /usr/share/perl5/vendor_perl/Monkey/Patch/Handle/Class.pm -rw-r--r-- 1 root root 646 juil. 31 17:37 /usr/share/perl5/vendor_perl/Monkey/Patch/Handle/Object.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-Monkey-Patch-0.03-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.0) 1 perl(base) 1 perl(Exporter) 1 perl(Monkey::Patch::Handle) 1 perl(Monkey::Patch::Handle::Class) 1 perl(Monkey::Patch::Handle::Object) 1 perl(Scalar::Util) 1 perl(strict) 2 perl(Sub::Delete) 2 perl(SUPER) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p perl-Monkey-Patch-0.03-1.fc29.noarch.rpm perl(Monkey::Patch) = 0.03 perl(Monkey::Patch::Handle) = 0.03 perl(Monkey::Patch::Handle::Class) = 0.03 perl(Monkey::Patch::Handle::Object) = 0.03 perl-Monkey-Patch = 0.03-1.fc29 Binary provides are Ok. Package builds in mock F29. Ok The package is in line with Fedora and Perl packaging guidelines. Resolution: Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/HR7DUPPINRXNPT74FRQUQ2VFN3EXIK7J/
