[Bug 1610231] Review Request: perl-Sub-Delete - Perl module to delete subroutines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1610231

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
4435a70b01a80d6e91dd3749f29734cf2c36207e7aeb537d8c96d231fe2951ee) is original.
Ok.
Summary verified from lib/Sub/Delete.pm. Ok.
Description verified from lib/Sub/Delete.pm. Ok.
License verified from lib/Sub/Delete.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-Sub-Delete.spec
review-perl-Sub-Delete/results/perl-Sub-Delete-1.00002-1.fc29.noarch.rpm
review-perl-Sub-Delete/results/perl-Sub-Delete-1.00002-1.fc29.src.rpm 
perl-Sub-Delete.noarch: W: spelling-error %description -l en_US undefine ->
undefined, defined, define
perl-Sub-Delete.noarch: W: spelling-error %description -l en_US undef -> unfed,
under, funded
perl-Sub-Delete.src: W: spelling-error %description -l en_US undefine ->
undefined, defined, define
perl-Sub-Delete.src: W: spelling-error %description -l en_US undef -> unfed,
under, funded
2 packages and 1 specfiles checked; 0 errors, 4 warnings.


$ rpm -q -lv -p perl-Sub-Delete-1.00002-1.fc29.noarch.rpm 
drwxr-xr-x    2 root    root                        0 juil. 31 17:15
/usr/share/doc/perl-Sub-Delete
-rw-r--r--    1 root    root                     1183 avril 15  2010
/usr/share/doc/perl-Sub-Delete/Changes
-rw-r--r--    1 root    root                     2181 juil. 31 17:15
/usr/share/man/man3/Sub::Delete.3pm.gz
drwxr-xr-x    2 root    root                        0 juil. 31 17:15
/usr/share/perl5/vendor_perl/Sub
-rw-r--r--    1 root    root                     3791 avril 13  2010
/usr/share/perl5/vendor_perl/Sub/Delete.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-Sub-Delete-1.00002-1.fc29.noarch.rpm | sort -f |
uniq -c
      1 perl(:MODULE_COMPAT_5.28.0)
      1 perl(:VERSION) >= 5.8.3
      1 perl(constant)
      1 perl(Exporter) >= 5.57
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p perl-Sub-Delete-1.00002-1.fc29.noarch.rpm
perl(Sub::Delete) = 1.00002
perl-Sub-Delete = 1.00002-1.fc29
Binary provides are Ok.


Package builds in F29
(https://koji.fedoraproject.org/koji/taskinfo?taskID=28740994)
Ok

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/ALVIVGYVHK36QX2X6CLD6TWKDYEWZYV7/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux