[Bug 1609285] Review Request: chafa - Image-to-text converter for terminal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1609285



--- Comment #3 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
(In reply to Miro Hrončok from comment #2)
> >  - Patch the obsolete m4 macro in configure.ac:
> > 
> > AutoTools: Obsoleted m4s found
> > ------------------------------
> >   AM_PROG_LIBTOOL found in: chafa-0.9.0/configure.ac:36
> 
> Could you help? No idea what shall I do or if configure.ac is even used when
> configure is there.
> 
Sure. See
https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html

AM_PROG_LIBTOOL is obsolete, replace it with LT_INIT

I sent the patch upstream: you can grab it here:

Patch0:        
https://patch-diff.githubusercontent.com/raw/hpjansson/chafa/pull/4.patch#/%{name}-%{version}-fix_obsolete_m4_macro.patch

You'll need to re-run autoreconf -ivf before sed since configure.ac has
changed.


 - Fix your Requires for the main package, you still have lib instead of libs:

Requires:       %{name}-libs%{?_isa} = %{version}-%{release}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/SPTX6BBVOUJM4SOWEDHMKQUYTABW5RDZ/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux