[Bug 1609285] Review Request: chafa - Image-to-text converter for terminal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1609285



--- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
(In reply to Robert-André Mauchin from comment #1)
>  - add a changelog

Added.

>  - the way you define summary is not ok, it's always taking the previous one
> not the first one

Good catch. Changed.


>  - remove the rpath

Done.


>  - Patch the obsolete m4 macro in configure.ac:
> 
> AutoTools: Obsoleted m4s found
> ------------------------------
>   AM_PROG_LIBTOOL found in: chafa-0.9.0/configure.ac:36

Could you help? No idea what shall I do or if configure.ac is even used when
configure is there.


I've also renamed lib subpackage to libs to make rpmlint happy about:

chafa-devel.x86_64: W: no-dependency-on chafa/chafa-libs/libchafa



Spec URL: https://churchyard.fedorapeople.org/SRPMS/chafa.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/chafa-0.9.0-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/BWODJR2JMU7Z63UALFJBMCOIA7XUUHWS/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux