https://bugzilla.redhat.com/show_bug.cgi?id=1601058 --- Comment #6 from Chris King <bunnyapoc@xxxxxxxxx> --- (In reply to Chris King from comment #5) > (In reply to Michael Catanzaro from comment #3) > > Is it conventional to use uppercase in package names? I would probably call > > it "wpebackend". > > > > I'd use a glob in the file list: > > > > %{_includedir}/wpe-0.1/wpe/*.h > > > > because you don't want the build to break every time a header gets added or > > removed. (Only two of the headers may be used directly by applications, and > > they won't disappear unexpectedly.) > > > > You will surely want to use a glob to avoid build failures when the last two > > components of the soversion change in every release: > > > > %{_libdir}/libWPEBackend-0.1.so.0.* > > > > Looks like you have one extra space here in the devel package requires: > > > > Requires: %{name}%{?_isa} = %{version}-%{release} > > Thanks for the tips, I have changed the spec file accordingly. I have also > changed the name Shoot, it did not occur to me that clicking save changes on one part of the bug report page would submit all areas that have text entered until I did it, oops. .... As I was saying, I have changed the spec and the name in the spec to address your comments, however, the copr repository is still named WPE-backend as there is no way to change the name of that to my knowledge. New spec: https://copr-be.cloud.fedoraproject.org/results/bunnyapocalypse/WPE-backend/fedora-rawhide-x86_64/00777348-wpebackend/wpebackend.spec Additionally, I have now created a request for the main WPE package here: https://bugzilla.redhat.com/show_bug.cgi?id=1601186 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/L636RWD3T3V2G5XQJQYTH2FXGCAHRE3V/
