https://bugzilla.redhat.com/show_bug.cgi?id=1601058 Chris King <bunnyapoc@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: WPE-backend |Review Request: wpebackend |- Backend needed for the |- Library needed for the |WPE-flavored port of |WPE-flavored port of |WebKit. |WebKit. --- Comment #5 from Chris King <bunnyapoc@xxxxxxxxx> --- (In reply to Michael Catanzaro from comment #3) > Is it conventional to use uppercase in package names? I would probably call > it "wpebackend". > > I'd use a glob in the file list: > > %{_includedir}/wpe-0.1/wpe/*.h > > because you don't want the build to break every time a header gets added or > removed. (Only two of the headers may be used directly by applications, and > they won't disappear unexpectedly.) > > You will surely want to use a glob to avoid build failures when the last two > components of the soversion change in every release: > > %{_libdir}/libWPEBackend-0.1.so.0.* > > Looks like you have one extra space here in the devel package requires: > > Requires: %{name}%{?_isa} = %{version}-%{release} Thanks for the tips, I have changed the spec file accordingly. I have also changed the name -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/GXMQBEOUUZPFTRRM2AGQ6LC5GHIDERO3/
