https://bugzilla.redhat.com/show_bug.cgi?id=1582983 Rex Dieter <rdieter@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ewalsh@xxxxxxxxxxxxxxxxx Flags| |fedora-review? | |needinfo?(ewalsh@termyseque | |nce.com) --- Comment #9 from Rex Dieter <rdieter@xxxxxxxxx> --- Looking this over I have a couple of questions: 1. termy-server and termy-qt both come from common source, https://termysequence.io/releases/termysequence-%{version}.tar.xz So, why package them seperately? Typically, you'd build from a single source package and generate multiple subpackages instead. 2. Why use -DCMAKE_BUILD_TYPE=None ?? (hint: please document the reasoning in a .spec comment) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/TXJ54KUDRRER3R3ZTU75G7S7PMULC572/
