[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1578103

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|                            |fedora-review+



--- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
> I actually did send a PR to update Inconsolata but the maintainer is Kevin Fenzi and he is a very busy man.

Good! So once the inconsolata package is updated (whenever that may be), you
can unbundle that font, too.


Typo alarm:
-----------

You made a small mistake when you "refactored" the -doc subpackage (you missed
to drop the -n flag), so the doc (sub)package is now really named only "doc" -
which is probably not what you wanted

You can just drop the "-n" flag for the "doc" subpackage in the %package,
%description, and %files stanzas before importing the package - I won't block
the review on that.


Otherwise:
Package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/C2WSZ3Y7OBJD7EEEYQNPXU7LFFLITYX5/




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux