https://bugzilla.redhat.com/show_bug.cgi?id=1578103 --- Comment #5 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #4) > ISSUES > ====== > > 1) The "%package -n python-%{pypi_name}-doc" can just be "%package doc". Same > goes for "%description" and %files" stanzas. > Ok. > 2) You'll also need to add these to the "-doc" subpackage, otherwise the > installed package will only have broken symlinks (see rpmlint messages): > > Requires: fontawesome-fonts > Requires: fontawesome-fonts-web > Requires: lato-fonts > Requires: google-roboto-slab-fonts > Requires: js-underscore > Requires: js-jquery > Ooops you're right. > 3) Since you're bundling inconsolata, you'll also need to add this to the > "-doc" > subpackage: > > Provides: bundled(levien-inconsolata-fonts) Ok. > > It would be nice if you could ping the maintainer of the inconsolata fonts in > fedora to update the package so you could unbundle those in a future version > of > this package, but that's probably out of the scope of this review. > I actually did send a PR to update Inconsolata but the maintainer is Kevin Fenzi and he is a very busy man. https://src.fedoraproject.org/rpms/levien-inconsolata-fonts/pull-request/1 > > With those 3 issues fixed, I'll approve the package. (Detailed review below.) > Spec URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/python-twisted/fedora-rawhide-x86_64/00763687-python-hyperlink/python-hyperlink.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/python-twisted/fedora-rawhide-x86_64/00763687-python-hyperlink/python-hyperlink-18.0.0-1.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx/message/US6UXWA5BQE4R3JF4DCPUQLTVZK4OR4X/
